comparison bits/DefaultPluginOutputIdMapper.h @ 65:2d866edd79d5

Merge from noexcept branch

 	for (const auto &d: outputs) {
 	    m_ids.push_back(d.identifier);
 	}
     }
 
-    virtual int idToIndex(std::string outputId) const {
+    virtual int idToIndex(std::string outputId) const noexcept {
 	int n = int(m_ids.size());
 	for (int i = 0; i < n; ++i) {
 	    if (outputId == m_ids[i]) {
 		return i;
 	    }
 	}
-	//!!! todo: this should in fact throw, or otherwise return an error
-	return 0;
+	return -1;
     }
 
-    virtual std::string indexToId(int index) const {
-	//!!! todo: this should in fact throw, or otherwise return an error
+    virtual std::string indexToId(int index) const noexcept {
+        if (index < 0 || size_t(index) >= m_ids.size()) return "";
 	return m_ids[index];
     }
 
 private:
     std::vector<std::string> m_ids;