annotate vamp-support/CountingPluginHandleMapper.h @ 186:52322dde68ea

Fix erroneous logic for handling step and block size in prior commit The earlier change had a logical misconception. If PluginStub is receiving the correct step and block size back from the configure call, the plugin on the server side must have already been successfully initialised, as the step and block size are only returned in a successful configure response. This means the test for a failed initialise and redo with the correct parameters must be done on the server side (in LoaderRequests) not the client. The client has a more complicated job, which is to notice that a *successful* configure had returned different framing parameters from those passed to the initialise call, and to pretend that it had actually failed until the host called again with the correct parameters. We definitely need tests for this!
author Chris Cannam <cannam@all-day-breakfast.com>
date Mon, 06 Feb 2017 16:44:33 +0000
parents 427c4c725085
children 4b581a498981
rev   line source
c@75 1 /* -*- c-basic-offset: 4 indent-tabs-mode: nil -*- vi:set ts=8 sts=4 sw=4: */
c@75 2
c@75 3 /*
c@75 4 Piper C++
c@75 5
c@75 6 Centre for Digital Music, Queen Mary, University of London.
c@75 7 Copyright 2006-2016 Chris Cannam and QMUL.
c@75 8
c@75 9 Permission is hereby granted, free of charge, to any person
c@75 10 obtaining a copy of this software and associated documentation
c@75 11 files (the "Software"), to deal in the Software without
c@75 12 restriction, including without limitation the rights to use, copy,
c@75 13 modify, merge, publish, distribute, sublicense, and/or sell copies
c@75 14 of the Software, and to permit persons to whom the Software is
c@75 15 furnished to do so, subject to the following conditions:
c@75 16
c@75 17 The above copyright notice and this permission notice shall be
c@75 18 included in all copies or substantial portions of the Software.
c@75 19
c@75 20 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
c@75 21 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
c@75 22 MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
c@75 23 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR
c@75 24 ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
c@75 25 CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
c@75 26 WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
c@75 27
c@75 28 Except as contained in this notice, the names of the Centre for
c@75 29 Digital Music; Queen Mary, University of London; and Chris Cannam
c@75 30 shall not be used in advertising or otherwise to promote the sale,
c@75 31 use or other dealings in this Software without prior written
c@75 32 authorization.
c@75 33 */
c@75 34
c@75 35 #ifndef PIPER_COUNTING_PLUGIN_HANDLE_MAPPER_H
c@75 36 #define PIPER_COUNTING_PLUGIN_HANDLE_MAPPER_H
c@75 37
c@75 38 #include "PluginHandleMapper.h"
c@75 39 #include "PluginOutputIdMapper.h"
c@80 40 #include "AssignedPluginHandleMapper.h"
c@75 41
c@75 42 #include <set>
c@75 43 #include <map>
c@75 44
c@97 45 namespace piper_vamp {
c@75 46
c@75 47 class CountingPluginHandleMapper : public PluginHandleMapper
c@75 48 {
c@75 49 public:
c@75 50 CountingPluginHandleMapper() : m_nextHandle(1) { }
c@75 51
c@75 52 void addPlugin(Vamp::Plugin *p) {
c@80 53 Handle h = m_nextHandle++;
c@84 54 m_sub.addPlugin(h, p);
c@75 55 }
c@75 56
c@75 57 void removePlugin(Handle h) {
c@80 58 m_sub.removePlugin(h);
c@75 59 }
c@75 60
c@75 61 Handle pluginToHandle(Vamp::Plugin *p) const noexcept {
c@80 62 return m_sub.pluginToHandle(p);
c@75 63 }
c@75 64
c@75 65 Vamp::Plugin *handleToPlugin(Handle h) const noexcept {
c@80 66 return m_sub.handleToPlugin(h);
c@75 67 }
c@75 68
c@75 69 const std::shared_ptr<PluginOutputIdMapper> pluginToOutputIdMapper
c@75 70 (Vamp::Plugin *p) const noexcept {
c@80 71 return m_sub.pluginToOutputIdMapper(p);
c@75 72 }
c@75 73
c@75 74 const std::shared_ptr<PluginOutputIdMapper> handleToOutputIdMapper
c@75 75 (Handle h) const noexcept {
c@80 76 return m_sub.handleToOutputIdMapper(h);
c@75 77 }
c@75 78
c@75 79 bool isConfigured(Handle h) const noexcept {
c@80 80 return m_sub.isConfigured(h);
c@75 81 }
c@75 82
c@75 83 void markConfigured(Handle h, int channelCount, int blockSize) {
c@80 84 m_sub.markConfigured(h, channelCount, blockSize);
c@75 85 }
c@75 86
c@75 87 int getChannelCount(Handle h) const noexcept {
c@80 88 return m_sub.getChannelCount(h);
c@75 89 }
c@75 90
c@75 91 int getBlockSize(Handle h) const noexcept {
c@80 92 return m_sub.getBlockSize(h);
c@75 93 }
c@75 94
c@75 95 private:
c@75 96 Handle m_nextHandle; // NB plugin handle type must fit in JSON number
c@80 97 AssignedPluginHandleMapper m_sub;
c@75 98 };
c@75 99
c@75 100 }
c@75 101
c@75 102 #endif