Fix erroneous logic for handling step and block size in prior commit
The earlier change had a logical misconception. If PluginStub is
receiving the correct step and block size back from the configure call,
the plugin on the server side must have already been successfully
initialised, as the step and block size are only returned in a
successful configure response. This means the test for a failed
initialise and redo with the correct parameters must be done on the
server side (in LoaderRequests) not the client. The client has a more
complicated job, which is to notice that a *successful* configure had
returned different framing parameters from those passed to the
initialise call, and to pretend that it had actually failed until the
host called again with the correct parameters. We definitely need tests
for this!
| author |
Chris Cannam <cannam@all-day-breakfast.com> |
| date |
Mon, 06 Feb 2017 16:44:33 +0000 |
| parents |
e034075a2089 |
| children |
b0f0e257d8af |
| rev |
line source |
|
cannam@162
|
1
|
|
cannam@162
|
2 Piper
|
|
cannam@162
|
3 Copyright (c) 2015-2017 Queen Mary, University of London
|
|
cannam@162
|
4
|
|
cannam@162
|
5 Permission is hereby granted, free of charge, to any person
|
|
cannam@162
|
6 obtaining a copy of this software and associated documentation
|
|
cannam@162
|
7 files (the "Software"), to deal in the Software without
|
|
cannam@162
|
8 restriction, including without limitation the rights to use, copy,
|
|
cannam@162
|
9 modify, merge, publish, distribute, sublicense, and/or sell copies
|
|
cannam@162
|
10 of the Software, and to permit persons to whom the Software is
|
|
cannam@162
|
11 furnished to do so, subject to the following conditions:
|
|
cannam@162
|
12
|
|
cannam@162
|
13 The above copyright notice and this permission notice shall be
|
|
cannam@162
|
14 included in all copies or substantial portions of the Software.
|
|
cannam@162
|
15
|
|
cannam@162
|
16 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
cannam@162
|
17 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
cannam@162
|
18 MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
cannam@162
|
19 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
cannam@162
|
20 CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
|
|
cannam@162
|
21 CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
|
|
cannam@162
|
22 WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
cannam@162
|
23
|
|
cannam@162
|
24 Except as contained in this notice, the names of the Centre for
|
|
cannam@162
|
25 Digital Music; Queen Mary, University of London; and Chris Cannam
|
|
cannam@162
|
26 shall not be used in advertising or otherwise to promote the sale,
|
|
cannam@162
|
27 use or other dealings in this Software without prior written
|
|
cannam@162
|
28 authorization.
|
|
cannam@162
|
29
|
