changeset 3:2fc53e089662

Fix typo, link error, add comments
author Chris Cannam
date Fri, 07 Mar 2014 08:29:01 +0000
parents a84bae4ee627
children 9867e53a2592
files LowFreq.cpp Makefile.linux
diffstat 2 files changed, 7 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/LowFreq.cpp	Fri Mar 07 08:23:48 2014 +0000
+++ b/LowFreq.cpp	Fri Mar 07 08:29:01 2014 +0000
@@ -217,7 +217,7 @@
 	return false;
     }
 
-    if (m_p < minP || m_n > maxP) {
+    if (m_p < minP || m_p > maxP) {
 	cerr << "LowFreq::initialise: ERROR: shortest period " << m_p
 	     << " out of acceptable range " << minP
 	     << " -> " << maxP << endl;
@@ -305,6 +305,8 @@
     double *realOut = new double[m_n];
     double *imagOut = new double[m_n];
 
+    //!!! want window
+
     m_fft->process(false, m_buffer.data(), 0, realOut, imagOut);
 
     for (int i = 0; i <= m_n/2; ++i) {
@@ -313,6 +315,9 @@
 
     int step = m_n/2; //!!!
 
+    //!!! this output is wrong, it's described as one sample per step
+    //!!! but actually we have an overlap
+
     std::vector<double> advanced(m_buffer.data() + step,
 				 m_buffer.data() + m_buffer.size());
     
--- a/Makefile.linux	Fri Mar 07 08:23:48 2014 +0000
+++ b/Makefile.linux	Fri Mar 07 08:29:01 2014 +0000
@@ -4,7 +4,7 @@
 
 CXXFLAGS := $(CFLAGS)
 
-PLUGIN_LDFLAGS := -shared -Wl,-Bstatic -L../vamp-plugin-sdk -lvamp-sdk -Wl,-Bdynamic -Wl,--version-script=vamp-plugin.map
+PLUGIN_LDFLAGS := -shared -Wl,-Bstatic -L../qm-dsp -lqm-dsp -L../vamp-plugin-sdk -lvamp-sdk -Wl,-Bdynamic -Wl,--version-script=vamp-plugin.map
 TEST_LDFLAGS := -Wl,-Bstatic -L../vamp-plugin-sdk -lvamp-sdk -Wl,-Bdynamic -lboost_unit_test_framework
 
 PLUGIN_EXT := .so