comparison src/init.c @ 204:f262144347e7

Return XTRACT_ARGUMENT_ERROR if we try to initialise an mel filter bank with less than 2 bands

 
     mel_peak = height_norm = lin_peak = NULL;
     fft_peak = NULL;
     norm = 1;
 
+    if (freq_bands <= 1)
+    {
+        return XTRACT_ARGUMENT_ERROR;
+    }
+    
     mel_freq_max = 1127 * log(1 + freq_max / 700);
     mel_freq_min = 1127 * log(1 + freq_min / 700);
     freq_bw_mel = (mel_freq_max - mel_freq_min) / freq_bands;
 
     mel_peak = (double *)malloc((freq_bands + 2) * sizeof(double));

     lin_peak = (double *)malloc((freq_bands + 2) * sizeof(double));
     
     if (lin_peak == NULL)
     {
         perror("error");
+        free(mel_peak);
         return XTRACT_MALLOC_FAILED;
     }
     
     fft_peak = (int *)malloc((freq_bands + 2) * sizeof(int));
     
     if (fft_peak == NULL)
     {
         perror("error");
+        free(mel_peak);
+        free(lin_peak);
         return XTRACT_MALLOC_FAILED;
     }
     
     height_norm = (double *)malloc(freq_bands * sizeof(double));
     
     if (height_norm == NULL)
     {
         perror("error");
+        free(mel_peak);
+        free(lin_peak);
+        free(fft_peak);
         return XTRACT_MALLOC_FAILED;
     }
 
     M = N >> 1;
 
     mel_peak[0] = mel_freq_min;
     lin_peak[0] = freq_min; // === 700 * (exp(mel_peak[0] / 1127) - 1);
     fft_peak[0] = lin_peak[0] / nyquist * M;
 
 
-    for (n = 1; n < freq_bands + 2; n++)
+    for (n = 1; n < (freq_bands + 2); ++n)
     {
         //roll out peak locations - mel, linear and linear on fft window scale
         mel_peak[n] = mel_peak[n - 1] + freq_bw_mel;
         lin_peak[n] = 700 * (exp(mel_peak[n] / 1127) -1);
         fft_peak[n] = lin_peak[n] / nyquist * M;