annotate vendor/drupal/coder/coder_sniffer/DrupalPractice/Sniffs/Objects/GlobalDrupalSniff.php @ 19:fa3358dc1485 tip

Add ndrum files
author Chris Cannam
date Wed, 28 Aug 2019 13:14:47 +0100
parents 129ea1e6d783
children
rev   line source
Chris@0 1 <?php
Chris@0 2 /**
Chris@17 3 * \DrupalPractice\Sniffs\Objects\GlobalDrupalSniff.
Chris@0 4 *
Chris@0 5 * @category PHP
Chris@0 6 * @package PHP_CodeSniffer
Chris@0 7 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 8 */
Chris@0 9
Chris@17 10 namespace DrupalPractice\Sniffs\Objects;
Chris@17 11
Chris@17 12 use PHP_CodeSniffer\Files\File;
Chris@17 13 use PHP_CodeSniffer\Sniffs\Sniff;
Chris@17 14 use DrupalPractice\Project;
Chris@17 15
Chris@0 16 /**
Chris@0 17 * Checks that \Drupal::service() and friends is not used in forms, controllers, services.
Chris@0 18 *
Chris@0 19 * @category PHP
Chris@0 20 * @package PHP_CodeSniffer
Chris@0 21 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 22 */
Chris@17 23 class GlobalDrupalSniff implements Sniff
Chris@0 24 {
Chris@0 25
Chris@0 26 /**
Chris@0 27 * List of base classes where \Drupal should not be used in an extending class.
Chris@0 28 *
Chris@0 29 * @var string[]
Chris@0 30 */
Chris@0 31 public static $baseClasses = array(
Chris@0 32 'BlockBase',
Chris@0 33 'ConfigFormBase',
Chris@0 34 'ContentEntityForm',
Chris@0 35 'ControllerBase',
Chris@0 36 'EntityForm',
Chris@0 37 'EntityReferenceFormatterBase',
Chris@0 38 'FileFormatterBase',
Chris@0 39 'FormatterBase',
Chris@0 40 'FormBase',
Chris@0 41 'ImageFormatter',
Chris@0 42 'ImageFormatterBase',
Chris@0 43 'WidgetBase',
Chris@0 44 );
Chris@0 45
Chris@0 46
Chris@0 47 /**
Chris@0 48 * Returns an array of tokens this test wants to listen for.
Chris@0 49 *
Chris@0 50 * @return array
Chris@0 51 */
Chris@0 52 public function register()
Chris@0 53 {
Chris@0 54 return array(T_STRING);
Chris@0 55
Chris@0 56 }//end register()
Chris@0 57
Chris@0 58
Chris@0 59 /**
Chris@0 60 * Processes this test, when one of its tokens is encountered.
Chris@0 61 *
Chris@17 62 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
Chris@17 63 * @param int $stackPtr The position of the current token
Chris@17 64 * in the stack passed in $tokens.
Chris@0 65 *
Chris@0 66 * @return void
Chris@0 67 */
Chris@17 68 public function process(File $phpcsFile, $stackPtr)
Chris@0 69 {
Chris@0 70 $tokens = $phpcsFile->getTokens();
Chris@0 71
Chris@0 72 // We are only interested in Drupal:: static method calls, not in the global
Chris@0 73 // scope.
Chris@0 74 if ($tokens[$stackPtr]['content'] !== 'Drupal'
Chris@0 75 || $tokens[($stackPtr + 1)]['code'] !== T_DOUBLE_COLON
Chris@0 76 || isset($tokens[($stackPtr + 2)]) === false
Chris@0 77 || $tokens[($stackPtr + 2)]['code'] !== T_STRING
Chris@0 78 || isset($tokens[($stackPtr + 3)]) === false
Chris@0 79 || $tokens[($stackPtr + 3)]['code'] !== T_OPEN_PARENTHESIS
Chris@0 80 || empty($tokens[$stackPtr]['conditions']) === true
Chris@0 81 ) {
Chris@0 82 return;
Chris@0 83 }
Chris@0 84
Chris@0 85 // Check that this statement is not in a static function.
Chris@0 86 foreach ($tokens[$stackPtr]['conditions'] as $conditionPtr => $conditionCode) {
Chris@0 87 if ($conditionCode === T_FUNCTION && $phpcsFile->getMethodProperties($conditionPtr)['is_static'] === true) {
Chris@0 88 return;
Chris@0 89 }
Chris@0 90 }
Chris@0 91
Chris@0 92 // Check if the class extends another class and get the name of the class
Chris@0 93 // that is extended.
Chris@0 94 $classPtr = key($tokens[$stackPtr]['conditions']);
Chris@0 95 $extendsName = $phpcsFile->findExtendedClassName($classPtr);
Chris@0 96
Chris@0 97 if (($extendsName === false || in_array($extendsName, static::$baseClasses) === false)
Chris@17 98 && Project::isServiceClass($phpcsFile, $classPtr) === false
Chris@0 99 ) {
Chris@0 100 return;
Chris@0 101 }
Chris@0 102
Chris@0 103 $warning = '\Drupal calls should be avoided in classes, use dependency injection instead';
Chris@0 104 $phpcsFile->addWarning($warning, $stackPtr, 'GlobalDrupal');
Chris@0 105
Chris@0 106 }//end process()
Chris@0 107
Chris@0 108
Chris@0 109 }//end class