Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@17
|
3 * \DrupalPractice\Sniffs\FunctionCalls\TCheckPlainSniff
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@17
|
10 namespace DrupalPractice\Sniffs\FunctionCalls;
|
Chris@17
|
11
|
Chris@17
|
12 use PHP_CodeSniffer\Files\File;
|
Chris@17
|
13 use Drupal\Sniffs\Semantics\FunctionCall;
|
Chris@17
|
14
|
Chris@0
|
15 /**
|
Chris@0
|
16 * Check that "@" and "%" placeholders in t()/watchdog() are not escaped twice
|
Chris@0
|
17 * with check_plain().
|
Chris@0
|
18 *
|
Chris@0
|
19 * @category PHP
|
Chris@0
|
20 * @package PHP_CodeSniffer
|
Chris@0
|
21 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
22 */
|
Chris@17
|
23 class TCheckPlainSniff extends FunctionCall
|
Chris@0
|
24 {
|
Chris@0
|
25
|
Chris@0
|
26
|
Chris@0
|
27 /**
|
Chris@0
|
28 * Returns an array of function names this test wants to listen for.
|
Chris@0
|
29 *
|
Chris@0
|
30 * @return array
|
Chris@0
|
31 */
|
Chris@0
|
32 public function registerFunctionNames()
|
Chris@0
|
33 {
|
Chris@0
|
34 return array(
|
Chris@0
|
35 't',
|
Chris@0
|
36 'watchdog',
|
Chris@0
|
37 );
|
Chris@0
|
38
|
Chris@0
|
39 }//end registerFunctionNames()
|
Chris@0
|
40
|
Chris@0
|
41
|
Chris@0
|
42 /**
|
Chris@0
|
43 * Processes this function call.
|
Chris@0
|
44 *
|
Chris@17
|
45 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
|
Chris@17
|
46 * @param int $stackPtr The position of the function call in
|
Chris@17
|
47 * the stack.
|
Chris@17
|
48 * @param int $openBracket The position of the opening
|
Chris@17
|
49 * parenthesis in the stack.
|
Chris@17
|
50 * @param int $closeBracket The position of the closing
|
Chris@17
|
51 * parenthesis in the stack.
|
Chris@0
|
52 *
|
Chris@0
|
53 * @return void
|
Chris@0
|
54 */
|
Chris@0
|
55 public function processFunctionCall(
|
Chris@17
|
56 File $phpcsFile,
|
Chris@0
|
57 $stackPtr,
|
Chris@0
|
58 $openBracket,
|
Chris@0
|
59 $closeBracket
|
Chris@0
|
60 ) {
|
Chris@0
|
61 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
62 if ($tokens[$stackPtr]['content'] === 't') {
|
Chris@0
|
63 $argument = $this->getArgument(2);
|
Chris@0
|
64 } else {
|
Chris@0
|
65 // For watchdog() the placeholders are in the third argument.
|
Chris@0
|
66 $argument = $this->getArgument(3);
|
Chris@0
|
67 }
|
Chris@0
|
68
|
Chris@0
|
69 if ($argument === false) {
|
Chris@0
|
70 return;
|
Chris@0
|
71 }
|
Chris@0
|
72
|
Chris@0
|
73 if ($tokens[$argument['start']]['code'] !== T_ARRAY) {
|
Chris@0
|
74 return;
|
Chris@0
|
75 }
|
Chris@0
|
76
|
Chris@0
|
77 $checkPlain = $argument['start'];
|
Chris@0
|
78 while (($checkPlain = $phpcsFile->findNext(T_STRING, ($checkPlain + 1), $tokens[$argument['start']]['parenthesis_closer'])) !== false) {
|
Chris@0
|
79 if ($tokens[$checkPlain]['content'] === 'check_plain') {
|
Chris@0
|
80 // The check_plain() could be embedded with string concatenation,
|
Chris@0
|
81 // which we want to allow.
|
Chris@0
|
82 $previous = $phpcsFile->findPrevious(T_WHITESPACE, ($checkPlain - 1), $argument['start'], true);
|
Chris@0
|
83 if ($previous === false || $tokens[$previous]['code'] !== T_STRING_CONCAT) {
|
Chris@0
|
84 $warning = 'The extra check_plain() is not necessary for placeholders, "@" and "%" will automatically run check_plain()';
|
Chris@0
|
85 $phpcsFile->addWarning($warning, $checkPlain, 'CheckPlain');
|
Chris@0
|
86 }
|
Chris@0
|
87 }
|
Chris@0
|
88 }
|
Chris@0
|
89
|
Chris@0
|
90 }//end processFunctionCall()
|
Chris@0
|
91
|
Chris@0
|
92
|
Chris@0
|
93 }//end class
|