Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@17
|
3 * \DrupalPractice\Sniffs\General\AccessAdminPagesSniff
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@17
|
10 namespace DrupalPractice\Sniffs\General;
|
Chris@17
|
11
|
Chris@17
|
12 use PHP_CodeSniffer\Files\File;
|
Chris@17
|
13 use Drupal\Sniffs\Semantics\FunctionDefinition;
|
Chris@17
|
14
|
Chris@0
|
15 /**
|
Chris@0
|
16 * Throws a warning if the "access administration pages" string is found in
|
Chris@0
|
17 * hook_menu().
|
Chris@0
|
18 *
|
Chris@0
|
19 * @category PHP
|
Chris@0
|
20 * @package PHP_CodeSniffer
|
Chris@0
|
21 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
22 */
|
Chris@17
|
23 class AccessAdminPagesSniff extends FunctionDefinition
|
Chris@0
|
24 {
|
Chris@0
|
25
|
Chris@0
|
26
|
Chris@0
|
27 /**
|
Chris@0
|
28 * Process this function definition.
|
Chris@0
|
29 *
|
Chris@17
|
30 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
|
Chris@17
|
31 * @param int $stackPtr The position of the function
|
Chris@17
|
32 * name in the stack.
|
Chris@17
|
33 * @param int $functionPtr The position of the function
|
Chris@17
|
34 * keyword in the stack.
|
Chris@0
|
35 *
|
Chris@0
|
36 * @return void
|
Chris@0
|
37 */
|
Chris@17
|
38 public function processFunction(File $phpcsFile, $stackPtr, $functionPtr)
|
Chris@0
|
39 {
|
Chris@0
|
40 $fileExtension = strtolower(substr($phpcsFile->getFilename(), -6));
|
Chris@0
|
41 // Only check in *.module files.
|
Chris@0
|
42 if ($fileExtension !== 'module') {
|
Chris@0
|
43 return;
|
Chris@0
|
44 }
|
Chris@0
|
45
|
Chris@0
|
46 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
47
|
Chris@0
|
48 $fileName = substr(basename($phpcsFile->getFilename()), 0, -7);
|
Chris@0
|
49 if ($tokens[$stackPtr]['content'] !== ($fileName.'_menu')) {
|
Chris@0
|
50 return;
|
Chris@0
|
51 }
|
Chris@0
|
52
|
Chris@0
|
53 // Search in the function body for "access administration pages" strings.
|
Chris@0
|
54 $string = $phpcsFile->findNext(
|
Chris@0
|
55 T_CONSTANT_ENCAPSED_STRING,
|
Chris@0
|
56 $tokens[$functionPtr]['scope_opener'],
|
Chris@0
|
57 $tokens[$functionPtr]['scope_closer']
|
Chris@0
|
58 );
|
Chris@0
|
59
|
Chris@0
|
60 while ($string !== false) {
|
Chris@0
|
61 if (substr($tokens[$string]['content'], 1, -1) === 'access administration pages') {
|
Chris@0
|
62 $warning = 'The administration menu callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.';
|
Chris@0
|
63 $phpcsFile->addWarning($warning, $string, 'PermissionFound');
|
Chris@0
|
64 }
|
Chris@0
|
65
|
Chris@0
|
66 $string = $phpcsFile->findNext(
|
Chris@0
|
67 T_CONSTANT_ENCAPSED_STRING,
|
Chris@0
|
68 ($string + 1),
|
Chris@0
|
69 $tokens[$functionPtr]['scope_closer']
|
Chris@0
|
70 );
|
Chris@0
|
71 }//end while
|
Chris@0
|
72
|
Chris@0
|
73 }//end processFunction()
|
Chris@0
|
74
|
Chris@0
|
75
|
Chris@0
|
76 }//end class
|