Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@0
|
3 * DrupalPractice_Sniffs_Constants_GlobalDefineSniff
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@0
|
10 /**
|
Chris@0
|
11 * Checks that global define() constants are not used in modules in Drupal 8.
|
Chris@0
|
12 *
|
Chris@0
|
13 * @category PHP
|
Chris@0
|
14 * @package PHP_CodeSniffer
|
Chris@0
|
15 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
16 */
|
Chris@0
|
17 class DrupalPractice_Sniffs_Constants_GlobalDefineSniff extends Drupal_Sniffs_Semantics_FunctionCall
|
Chris@0
|
18 {
|
Chris@0
|
19
|
Chris@0
|
20
|
Chris@0
|
21 /**
|
Chris@0
|
22 * Returns an array of function names this test wants to listen for.
|
Chris@0
|
23 *
|
Chris@0
|
24 * @return array
|
Chris@0
|
25 */
|
Chris@0
|
26 public function registerFunctionNames()
|
Chris@0
|
27 {
|
Chris@0
|
28 return array('define');
|
Chris@0
|
29
|
Chris@0
|
30 }//end registerFunctionNames()
|
Chris@0
|
31
|
Chris@0
|
32
|
Chris@0
|
33 /**
|
Chris@0
|
34 * Processes this function call.
|
Chris@0
|
35 *
|
Chris@0
|
36 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
Chris@0
|
37 * @param int $stackPtr The position of the function call in
|
Chris@0
|
38 * the stack.
|
Chris@0
|
39 * @param int $openBracket The position of the opening
|
Chris@0
|
40 * parenthesis in the stack.
|
Chris@0
|
41 * @param int $closeBracket The position of the closing
|
Chris@0
|
42 * parenthesis in the stack.
|
Chris@0
|
43 *
|
Chris@0
|
44 * @return void
|
Chris@0
|
45 */
|
Chris@0
|
46 public function processFunctionCall(
|
Chris@0
|
47 PHP_CodeSniffer_File $phpcsFile,
|
Chris@0
|
48 $stackPtr,
|
Chris@0
|
49 $openBracket,
|
Chris@0
|
50 $closeBracket
|
Chris@0
|
51 ) {
|
Chris@0
|
52 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
53
|
Chris@0
|
54 // Only check constants in the global scope in module files.
|
Chris@0
|
55 if (empty($tokens[$stackPtr]['conditions']) === false || substr($phpcsFile->getFilename(), -7) !== '.module') {
|
Chris@0
|
56 return;
|
Chris@0
|
57 }
|
Chris@0
|
58
|
Chris@0
|
59 $coreVersion = DrupalPractice_Project::getCoreVersion($phpcsFile);
|
Chris@0
|
60 if ($coreVersion !== '8.x') {
|
Chris@0
|
61 return;
|
Chris@0
|
62 }
|
Chris@0
|
63
|
Chris@0
|
64 // Allow constants if they are deprecated.
|
Chris@0
|
65 $commentEnd = $phpcsFile->findPrevious(T_WHITESPACE, ($stackPtr - 1), null, true);
|
Chris@0
|
66 if ($commentEnd !== null && $tokens[$commentEnd]['code'] === T_DOC_COMMENT_CLOSE_TAG) {
|
Chris@0
|
67 // Go through all comment tags and check if one is @deprecated.
|
Chris@0
|
68 $commentTag = $commentEnd;
|
Chris@0
|
69 while ($commentTag !== null && $commentTag > $tokens[$commentEnd]['comment_opener']) {
|
Chris@0
|
70 if ($tokens[$commentTag]['content'] === '@deprecated') {
|
Chris@0
|
71 return;
|
Chris@0
|
72 }
|
Chris@0
|
73
|
Chris@0
|
74 $commentTag = $phpcsFile->findPrevious(T_DOC_COMMENT_TAG, ($commentTag - 1), $tokens[$commentEnd]['comment_opener']);
|
Chris@0
|
75 }
|
Chris@0
|
76 }
|
Chris@0
|
77
|
Chris@0
|
78 $warning = 'Global constants should not be used, move it to a class or interface';
|
Chris@0
|
79 $phpcsFile->addWarning($warning, $stackPtr, 'GlobalConstant');
|
Chris@0
|
80
|
Chris@0
|
81 }//end processFunctionCall()
|
Chris@0
|
82
|
Chris@0
|
83
|
Chris@0
|
84 }//end class
|