annotate vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Strings/UnnecessaryStringConcatSniff.php @ 2:92f882872392

Trusted hosts, + remove migration modules
author Chris Cannam
date Tue, 05 Dec 2017 09:26:43 +0000
parents 4c8ae668cc8c
children 129ea1e6d783
rev   line source
Chris@0 1 <?php
Chris@0 2 /**
Chris@0 3 * Generic_Sniffs_Strings_UnnecessaryStringConcatSniff.
Chris@0 4 *
Chris@0 5 * @category PHP
Chris@0 6 * @package PHP_CodeSniffer
Chris@0 7 * @author Greg Sherwood <gsherwood@squiz.net>
Chris@0 8 * @copyright 2006 Squiz Pty Ltd (ABN 77 084 670 600)
Chris@0 9 * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
Chris@0 10 * @version CVS: $Id: UnnecessaryStringConcatSniff.php 304603 2010-10-22 03:07:04Z squiz $
Chris@0 11 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 12 */
Chris@0 13
Chris@0 14 /**
Chris@0 15 * Generic_Sniffs_Strings_UnnecessaryStringConcatSniff.
Chris@0 16 *
Chris@0 17 * Checks that two strings are not concatenated together; suggests
Chris@0 18 * using one string instead.
Chris@0 19 *
Chris@0 20 * @category PHP
Chris@0 21 * @package PHP_CodeSniffer
Chris@0 22 * @author Greg Sherwood <gsherwood@squiz.net>
Chris@0 23 * @copyright 2006 Squiz Pty Ltd (ABN 77 084 670 600)
Chris@0 24 * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
Chris@0 25 * @version Release: 1.3.1
Chris@0 26 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 27 */
Chris@0 28 class Drupal_Sniffs_Strings_UnnecessaryStringConcatSniff extends Generic_Sniffs_Strings_UnnecessaryStringConcatSniff
Chris@0 29 {
Chris@0 30
Chris@0 31
Chris@0 32 /**
Chris@0 33 * Processes this sniff, when one of its tokens is encountered.
Chris@0 34 *
Chris@0 35 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
Chris@0 36 * @param int $stackPtr The position of the current token
Chris@0 37 * in the stack passed in $tokens.
Chris@0 38 *
Chris@0 39 * @return void
Chris@0 40 */
Chris@0 41 public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
Chris@0 42 {
Chris@0 43 // Work out which type of file this is for.
Chris@0 44 $tokens = $phpcsFile->getTokens();
Chris@0 45 if ($tokens[$stackPtr]['code'] === T_STRING_CONCAT) {
Chris@0 46 if ($phpcsFile->tokenizerType === 'JS') {
Chris@0 47 return;
Chris@0 48 }
Chris@0 49 } else {
Chris@0 50 if ($phpcsFile->tokenizerType === 'PHP') {
Chris@0 51 return;
Chris@0 52 }
Chris@0 53 }
Chris@0 54
Chris@0 55 $prev = $phpcsFile->findPrevious(T_WHITESPACE, ($stackPtr - 1), null, true);
Chris@0 56 $next = $phpcsFile->findNext(T_WHITESPACE, ($stackPtr + 1), null, true);
Chris@0 57 if ($prev === false || $next === false) {
Chris@0 58 return;
Chris@0 59 }
Chris@0 60
Chris@0 61 $stringTokens = PHP_CodeSniffer_Tokens::$stringTokens;
Chris@0 62 if (in_array($tokens[$prev]['code'], $stringTokens) === true
Chris@0 63 && in_array($tokens[$next]['code'], $stringTokens) === true
Chris@0 64 ) {
Chris@0 65 if ($tokens[$prev]['content'][0] === $tokens[$next]['content'][0]) {
Chris@0 66 // Before we throw an error for PHP, allow strings to be
Chris@0 67 // combined if they would have < and ? next to each other because
Chris@0 68 // this trick is sometimes required in PHP strings.
Chris@0 69 if ($phpcsFile->tokenizerType === 'PHP') {
Chris@0 70 $prevChar = substr($tokens[$prev]['content'], -2, 1);
Chris@0 71 $nextChar = $tokens[$next]['content'][1];
Chris@0 72 $combined = $prevChar.$nextChar;
Chris@0 73 if ($combined === '?'.'>' || $combined === '<'.'?') {
Chris@0 74 return;
Chris@0 75 }
Chris@0 76 }
Chris@0 77
Chris@0 78 // Before we throw an error check if the string is longer than
Chris@0 79 // the line length limit.
Chris@0 80 $lineLengthLimitSniff = new Drupal_Sniffs_Files_LineLengthSniff;
Chris@0 81
Chris@0 82 $lineLenght = $lineLengthLimitSniff->getLineLength($phpcsFile, $tokens[$prev]['line']);
Chris@0 83 $stringLength = ($lineLenght + strlen($tokens[$next]['content']) - 4);
Chris@0 84 if ($stringLength > $lineLengthLimitSniff->lineLimit) {
Chris@0 85 return;
Chris@0 86 }
Chris@0 87
Chris@0 88 $error = 'String concat is not required here; use a single string instead';
Chris@0 89 if ($this->error === true) {
Chris@0 90 $phpcsFile->addError($error, $stackPtr, 'Found');
Chris@0 91 } else {
Chris@0 92 $phpcsFile->addWarning($error, $stackPtr, 'Found');
Chris@0 93 }
Chris@0 94 }//end if
Chris@0 95 }//end if
Chris@0 96
Chris@0 97 }//end process()
Chris@0 98
Chris@0 99
Chris@0 100 }//end class