Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@0
|
3 * Verifies that class/interface/trait methods have scope modifiers.
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@0
|
10 /**
|
Chris@0
|
11 * Verifies that class/interface/trait methods have scope modifiers.
|
Chris@0
|
12 *
|
Chris@0
|
13 * Laregely copied from Squiz_Sniffs_Scope_MethodScopeSniff to work on traits
|
Chris@0
|
14 * and have a fixer.
|
Chris@0
|
15 *
|
Chris@0
|
16 * @category PHP
|
Chris@0
|
17 * @package PHP_CodeSniffer
|
Chris@0
|
18 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
19 */
|
Chris@0
|
20 class Drupal_Sniffs_Scope_MethodScopeSniff extends PHP_CodeSniffer_Standards_AbstractScopeSniff
|
Chris@0
|
21 {
|
Chris@0
|
22
|
Chris@0
|
23
|
Chris@0
|
24 /**
|
Chris@0
|
25 * Constructs a Squiz_Sniffs_Scope_MethodScopeSniff.
|
Chris@0
|
26 */
|
Chris@0
|
27 public function __construct()
|
Chris@0
|
28 {
|
Chris@0
|
29 parent::__construct(array(T_CLASS, T_INTERFACE, T_TRAIT), array(T_FUNCTION));
|
Chris@0
|
30
|
Chris@0
|
31 }//end __construct()
|
Chris@0
|
32
|
Chris@0
|
33
|
Chris@0
|
34 /**
|
Chris@0
|
35 * Processes the function tokens within the class.
|
Chris@0
|
36 *
|
Chris@0
|
37 * @param PHP_CodeSniffer_File $phpcsFile The file where this token was found.
|
Chris@0
|
38 * @param int $stackPtr The position where the token was found.
|
Chris@0
|
39 * @param int $currScope The current scope opener token.
|
Chris@0
|
40 *
|
Chris@0
|
41 * @return void
|
Chris@0
|
42 */
|
Chris@0
|
43 protected function processTokenWithinScope(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $currScope)
|
Chris@0
|
44 {
|
Chris@0
|
45 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
46
|
Chris@0
|
47 $methodName = $phpcsFile->getDeclarationName($stackPtr);
|
Chris@0
|
48 if ($methodName === null) {
|
Chris@0
|
49 // Ignore closures.
|
Chris@0
|
50 return;
|
Chris@0
|
51 }
|
Chris@0
|
52
|
Chris@0
|
53 if ($phpcsFile->hasCondition($stackPtr, T_FUNCTION) === true) {
|
Chris@0
|
54 // Ignore nested functions.
|
Chris@0
|
55 return;
|
Chris@0
|
56 }
|
Chris@0
|
57
|
Chris@0
|
58 $modifier = null;
|
Chris@0
|
59 for ($i = ($stackPtr - 1); $i > 0; $i--) {
|
Chris@0
|
60 if ($tokens[$i]['line'] < $tokens[$stackPtr]['line']) {
|
Chris@0
|
61 break;
|
Chris@0
|
62 } else if (isset(PHP_CodeSniffer_Tokens::$scopeModifiers[$tokens[$i]['code']]) === true) {
|
Chris@0
|
63 $modifier = $i;
|
Chris@0
|
64 break;
|
Chris@0
|
65 }
|
Chris@0
|
66 }
|
Chris@0
|
67
|
Chris@0
|
68 if ($modifier === null) {
|
Chris@0
|
69 $error = 'Visibility must be declared on method "%s"';
|
Chris@0
|
70 $data = array($methodName);
|
Chris@0
|
71 $fix = $phpcsFile->addFixableError($error, $stackPtr, 'Missing', $data);
|
Chris@0
|
72
|
Chris@0
|
73 if ($fix === true) {
|
Chris@0
|
74 // No scope modifier means the method is public in PHP, fix that
|
Chris@0
|
75 // to be explicitly public.
|
Chris@0
|
76 $phpcsFile->fixer->addContentBefore($stackPtr, 'public ');
|
Chris@0
|
77 }
|
Chris@0
|
78 }
|
Chris@0
|
79
|
Chris@0
|
80 }//end processTokenWithinScope()
|
Chris@0
|
81
|
Chris@0
|
82
|
Chris@0
|
83 }//end class
|