Chris@0
|
1 <?php
|
Chris@0
|
2
|
Chris@0
|
3 /**
|
Chris@0
|
4 * DrupalPractice_Sniffs_Yaml_RoutingAccessSniff.
|
Chris@0
|
5 *
|
Chris@0
|
6 * @category PHP
|
Chris@0
|
7 * @package PHP_CodeSniffer
|
Chris@0
|
8 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
9 */
|
Chris@0
|
10
|
Chris@0
|
11 /**
|
Chris@0
|
12 * Checks that there are no undocumented open access callbacks in *.routing.yml files.
|
Chris@0
|
13 *
|
Chris@0
|
14 * Also adds a warning if the permission "access administration pages" is used.
|
Chris@0
|
15 *
|
Chris@0
|
16 * @category PHP
|
Chris@0
|
17 * @package PHP_CodeSniffer
|
Chris@0
|
18 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
19 */
|
Chris@0
|
20 class DrupalPractice_Sniffs_Yaml_RoutingAccessSniff implements PHP_CodeSniffer_Sniff
|
Chris@0
|
21 {
|
Chris@0
|
22
|
Chris@0
|
23
|
Chris@0
|
24 /**
|
Chris@0
|
25 * Returns an array of tokens this test wants to listen for.
|
Chris@0
|
26 *
|
Chris@0
|
27 * @return array
|
Chris@0
|
28 */
|
Chris@0
|
29 public function register()
|
Chris@0
|
30 {
|
Chris@0
|
31 return array(T_INLINE_HTML);
|
Chris@0
|
32
|
Chris@0
|
33 }//end register()
|
Chris@0
|
34
|
Chris@0
|
35
|
Chris@0
|
36 /**
|
Chris@0
|
37 * Processes this test, when one of its tokens is encountered.
|
Chris@0
|
38 *
|
Chris@0
|
39 * @param PHP_CodeSniffer_File $phpcsFile The current file being processed.
|
Chris@0
|
40 * @param int $stackPtr The position of the current token
|
Chris@0
|
41 * in the stack passed in $tokens.
|
Chris@0
|
42 *
|
Chris@0
|
43 * @return int
|
Chris@0
|
44 */
|
Chris@0
|
45 public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
Chris@0
|
46 {
|
Chris@0
|
47 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
48
|
Chris@0
|
49 $fileExtension = strtolower(substr($phpcsFile->getFilename(), -12));
|
Chris@0
|
50 if ($fileExtension !== '.routing.yml') {
|
Chris@0
|
51 return ($phpcsFile->numTokens + 1);
|
Chris@0
|
52 }
|
Chris@0
|
53
|
Chris@0
|
54 if (preg_match('/^[\s]+_access: \'TRUE\'/', $tokens[$stackPtr]['content']) === 1
|
Chris@0
|
55 && isset($tokens[($stackPtr - 1)]) === true
|
Chris@0
|
56 && preg_match('/^[\s]*#/', $tokens[($stackPtr - 1)]['content']) === 0
|
Chris@0
|
57 ) {
|
Chris@0
|
58 $warning = 'Open page callback found, please add a comment before the line why there is no access restriction';
|
Chris@0
|
59 $phpcsFile->addWarning($warning, $stackPtr, 'OpenCallback');
|
Chris@0
|
60 }
|
Chris@0
|
61
|
Chris@0
|
62 if (preg_match('/^[\s]+_permission: \'access administration pages\'/', $tokens[$stackPtr]['content']) === 1) {
|
Chris@0
|
63 $warning = 'The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.';
|
Chris@0
|
64 $phpcsFile->addWarning($warning, $stackPtr, 'PermissionFound');
|
Chris@0
|
65 }
|
Chris@0
|
66
|
Chris@0
|
67 }//end process()
|
Chris@0
|
68
|
Chris@0
|
69
|
Chris@0
|
70 }//end class
|