Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@0
|
3 * DrupalPractice_Sniffs_Objects_GlobalClassSniff.
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@0
|
10 /**
|
Chris@0
|
11 * Checks that Node::load() calls and friends are not used in forms, controllers or
|
Chris@0
|
12 * services.
|
Chris@0
|
13 *
|
Chris@0
|
14 * @category PHP
|
Chris@0
|
15 * @package PHP_CodeSniffer
|
Chris@0
|
16 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
17 */
|
Chris@0
|
18 class DrupalPractice_Sniffs_Objects_GlobalClassSniff implements PHP_CodeSniffer_Sniff
|
Chris@0
|
19 {
|
Chris@0
|
20
|
Chris@0
|
21 /**
|
Chris@0
|
22 * Class names that should not be called statically, mostly entity classes.
|
Chris@0
|
23 *
|
Chris@0
|
24 * @var string[]
|
Chris@0
|
25 */
|
Chris@0
|
26 protected $classes = array(
|
Chris@0
|
27 'File',
|
Chris@0
|
28 'Node',
|
Chris@0
|
29 'NodeType',
|
Chris@0
|
30 'Role',
|
Chris@0
|
31 'Term',
|
Chris@0
|
32 'User',
|
Chris@0
|
33 );
|
Chris@0
|
34
|
Chris@0
|
35
|
Chris@0
|
36 /**
|
Chris@0
|
37 * Returns an array of tokens this test wants to listen for.
|
Chris@0
|
38 *
|
Chris@0
|
39 * @return array
|
Chris@0
|
40 */
|
Chris@0
|
41 public function register()
|
Chris@0
|
42 {
|
Chris@0
|
43 return array(T_STRING);
|
Chris@0
|
44
|
Chris@0
|
45 }//end register()
|
Chris@0
|
46
|
Chris@0
|
47
|
Chris@0
|
48 /**
|
Chris@0
|
49 * Processes this test, when one of its tokens is encountered.
|
Chris@0
|
50 *
|
Chris@0
|
51 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
Chris@0
|
52 * @param int $stackPtr The position of the current token
|
Chris@0
|
53 * in the stack passed in $tokens.
|
Chris@0
|
54 *
|
Chris@0
|
55 * @return void
|
Chris@0
|
56 */
|
Chris@0
|
57 public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
Chris@0
|
58 {
|
Chris@0
|
59 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
60
|
Chris@0
|
61 // We are only interested in static class method calls, not in the global
|
Chris@0
|
62 // scope.
|
Chris@0
|
63 if (in_array($tokens[$stackPtr]['content'], $this->classes) === false
|
Chris@0
|
64 || $tokens[($stackPtr + 1)]['code'] !== T_DOUBLE_COLON
|
Chris@0
|
65 || isset($tokens[($stackPtr + 2)]) === false
|
Chris@0
|
66 || $tokens[($stackPtr + 2)]['code'] !== T_STRING
|
Chris@0
|
67 || in_array($tokens[($stackPtr + 2)]['content'], array('load', 'loadMultiple')) === false
|
Chris@0
|
68 || isset($tokens[($stackPtr + 3)]) === false
|
Chris@0
|
69 || $tokens[($stackPtr + 3)]['code'] !== T_OPEN_PARENTHESIS
|
Chris@0
|
70 || empty($tokens[$stackPtr]['conditions']) === true
|
Chris@0
|
71 ) {
|
Chris@0
|
72 return;
|
Chris@0
|
73 }
|
Chris@0
|
74
|
Chris@0
|
75 // Check that this statement is not in a static function.
|
Chris@0
|
76 foreach ($tokens[$stackPtr]['conditions'] as $conditionPtr => $conditionCode) {
|
Chris@0
|
77 if ($conditionCode === T_FUNCTION && $phpcsFile->getMethodProperties($conditionPtr)['is_static'] === true) {
|
Chris@0
|
78 return;
|
Chris@0
|
79 }
|
Chris@0
|
80 }
|
Chris@0
|
81
|
Chris@0
|
82 // Check if the class extends another class and get the name of the class
|
Chris@0
|
83 // that is extended.
|
Chris@0
|
84 $classPtr = key($tokens[$stackPtr]['conditions']);
|
Chris@0
|
85 $extendsName = $phpcsFile->findExtendedClassName($classPtr);
|
Chris@0
|
86
|
Chris@0
|
87 if (($extendsName === false
|
Chris@0
|
88 || in_array($extendsName, DrupalPractice_Sniffs_Objects_GlobalDrupalSniff::$baseClasses) === false)
|
Chris@0
|
89 && DrupalPractice_Project::isServiceClass($phpcsFile, $classPtr) === false
|
Chris@0
|
90 ) {
|
Chris@0
|
91 return;
|
Chris@0
|
92 }
|
Chris@0
|
93
|
Chris@0
|
94 $warning = '%s::%s calls should be avoided in classes, use dependency injection instead';
|
Chris@0
|
95 $data = array(
|
Chris@0
|
96 $tokens[$stackPtr]['content'],
|
Chris@0
|
97 $tokens[($stackPtr + 2)]['content'],
|
Chris@0
|
98 );
|
Chris@0
|
99 $phpcsFile->addWarning($warning, $stackPtr, 'GlobalClass', $data);
|
Chris@0
|
100
|
Chris@0
|
101 }//end process()
|
Chris@0
|
102
|
Chris@0
|
103
|
Chris@0
|
104 }//end class
|