annotate vendor/drupal/coder/coder_sniffer/DrupalPractice/Sniffs/FunctionDefinitions/AccessHookMenuSniff.php @ 12:7a779792577d

Update Drupal core to v8.4.5 (via Composer)
author Chris Cannam
date Fri, 23 Feb 2018 15:52:07 +0000
parents 4c8ae668cc8c
children 129ea1e6d783
rev   line source
Chris@0 1 <?php
Chris@0 2 /**
Chris@0 3 * DrupalPractice_Sniffs_FunctionDefinitions_AccessHookMenuSniff.
Chris@0 4 *
Chris@0 5 * @category PHP
Chris@0 6 * @package PHP_CodeSniffer
Chris@0 7 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 8 */
Chris@0 9
Chris@0 10 /**
Chris@0 11 * Checks that there are no undocumented open access callbacks in hook_menu().
Chris@0 12 *
Chris@0 13 * @category PHP
Chris@0 14 * @package PHP_CodeSniffer
Chris@0 15 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 16 */
Chris@0 17 class DrupalPractice_Sniffs_FunctionDefinitions_AccessHookMenuSniff extends Drupal_Sniffs_Semantics_FunctionDefinition
Chris@0 18 {
Chris@0 19
Chris@0 20
Chris@0 21 /**
Chris@0 22 * Process this function definition.
Chris@0 23 *
Chris@0 24 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
Chris@0 25 * @param int $stackPtr The position of the function name
Chris@0 26 * in the stack.
Chris@0 27 * @param int $functionPtr The position of the function keyword
Chris@0 28 * in the stack.
Chris@0 29 *
Chris@0 30 * @return void
Chris@0 31 */
Chris@0 32 public function processFunction(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $functionPtr)
Chris@0 33 {
Chris@0 34 $fileExtension = strtolower(substr($phpcsFile->getFilename(), -6));
Chris@0 35 // Only check in *.module files.
Chris@0 36 if ($fileExtension !== 'module') {
Chris@0 37 return;
Chris@0 38 }
Chris@0 39
Chris@0 40 $fileName = substr(basename($phpcsFile->getFilename()), 0, -7);
Chris@0 41 $tokens = $phpcsFile->getTokens();
Chris@0 42 if ($tokens[$stackPtr]['content'] !== ($fileName.'_menu')) {
Chris@0 43 return;
Chris@0 44 }
Chris@0 45
Chris@0 46 // Search for 'access callabck' => TRUE in the function body.
Chris@0 47 $string = $phpcsFile->findNext(
Chris@0 48 T_CONSTANT_ENCAPSED_STRING,
Chris@0 49 $tokens[$functionPtr]['scope_opener'],
Chris@0 50 $tokens[$functionPtr]['scope_closer']
Chris@0 51 );
Chris@0 52 while ($string !== false) {
Chris@0 53 if (substr($tokens[$string]['content'], 1, -1) === 'access callback') {
Chris@0 54 $array_operator = $phpcsFile->findNext(
Chris@0 55 PHP_CodeSniffer_Tokens::$emptyTokens,
Chris@0 56 ($string + 1),
Chris@0 57 null,
Chris@0 58 true
Chris@0 59 );
Chris@0 60 if ($array_operator !== false
Chris@0 61 && $tokens[$array_operator]['code'] === T_DOUBLE_ARROW
Chris@0 62 ) {
Chris@0 63 $callback = $phpcsFile->findNext(
Chris@0 64 PHP_CodeSniffer_Tokens::$emptyTokens,
Chris@0 65 ($array_operator + 1),
Chris@0 66 null,
Chris@0 67 true
Chris@0 68 );
Chris@0 69 if ($callback !== false && $tokens[$callback]['code'] === T_TRUE) {
Chris@0 70 // Check if there is a comment before the line that might
Chris@0 71 // explain stuff.
Chris@0 72 $commentBefore = $phpcsFile->findPrevious(
Chris@0 73 T_WHITESPACE,
Chris@0 74 ($string - 1),
Chris@0 75 $tokens[$functionPtr]['scope_opener'],
Chris@0 76 true
Chris@0 77 );
Chris@0 78 if ($commentBefore !== false && in_array($tokens[$commentBefore]['code'], PHP_CodeSniffer_Tokens::$commentTokens) === false) {
Chris@0 79 $warning = 'Open page callback found, please add a comment before the line why there is no access restriction';
Chris@0 80 $phpcsFile->addWarning($warning, $callback, 'OpenCallback');
Chris@0 81 }
Chris@0 82 }
Chris@0 83 }//end if
Chris@0 84 }//end if
Chris@0 85
Chris@0 86 $string = $phpcsFile->findNext(
Chris@0 87 T_CONSTANT_ENCAPSED_STRING,
Chris@0 88 ($string + 1),
Chris@0 89 $tokens[$functionPtr]['scope_closer']
Chris@0 90 );
Chris@0 91 }//end while
Chris@0 92
Chris@0 93 }//end processFunction()
Chris@0 94
Chris@0 95
Chris@0 96 }//end class