Chris@0
|
1 <?php
|
Chris@0
|
2 /**
|
Chris@0
|
3 * Drupal_Sniffs_Semantics_EmptyInstallSniff.
|
Chris@0
|
4 *
|
Chris@0
|
5 * @category PHP
|
Chris@0
|
6 * @package PHP_CodeSniffer
|
Chris@0
|
7 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
8 */
|
Chris@0
|
9
|
Chris@0
|
10 /**
|
Chris@0
|
11 * Throws an error if hook_install() or hook_uninstall() definitions are empty.
|
Chris@0
|
12 *
|
Chris@0
|
13 * @category PHP
|
Chris@0
|
14 * @package PHP_CodeSniffer
|
Chris@0
|
15 * @link http://pear.php.net/package/PHP_CodeSniffer
|
Chris@0
|
16 */
|
Chris@0
|
17 class Drupal_Sniffs_Semantics_EmptyInstallSniff extends Drupal_Sniffs_Semantics_FunctionDefinition
|
Chris@0
|
18 {
|
Chris@0
|
19
|
Chris@0
|
20
|
Chris@0
|
21 /**
|
Chris@0
|
22 * Process this function definition.
|
Chris@0
|
23 *
|
Chris@0
|
24 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
Chris@0
|
25 * @param int $stackPtr The position of the function name in the stack.
|
Chris@0
|
26 * name in the stack.
|
Chris@0
|
27 * @param int $functionPtr The position of the function keyword in the stack.
|
Chris@0
|
28 * keyword in the stack.
|
Chris@0
|
29 *
|
Chris@0
|
30 * @return void
|
Chris@0
|
31 */
|
Chris@0
|
32 public function processFunction(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $functionPtr)
|
Chris@0
|
33 {
|
Chris@0
|
34 $fileExtension = strtolower(substr($phpcsFile->getFilename(), -7));
|
Chris@0
|
35 // Only check in *.install files.
|
Chris@0
|
36 if ($fileExtension !== 'install') {
|
Chris@0
|
37 return;
|
Chris@0
|
38 }
|
Chris@0
|
39
|
Chris@0
|
40 $fileName = substr(basename($phpcsFile->getFilename()), 0, -8);
|
Chris@0
|
41 $tokens = $phpcsFile->getTokens();
|
Chris@0
|
42 if ($tokens[$stackPtr]['content'] === ($fileName.'_install')
|
Chris@0
|
43 || $tokens[$stackPtr]['content'] === ($fileName.'_uninstall')
|
Chris@0
|
44 ) {
|
Chris@0
|
45 // Check if there is a function body.
|
Chris@0
|
46 $bodyPtr = $phpcsFile->findNext(
|
Chris@0
|
47 PHP_CodeSniffer_Tokens::$emptyTokens,
|
Chris@0
|
48 ($tokens[$functionPtr]['scope_opener'] + 1),
|
Chris@0
|
49 $tokens[$functionPtr]['scope_closer'],
|
Chris@0
|
50 true
|
Chris@0
|
51 );
|
Chris@0
|
52 if ($bodyPtr === false) {
|
Chris@0
|
53 $error = 'Empty installation hooks are not necessary';
|
Chris@0
|
54 $phpcsFile->addError($error, $stackPtr, 'EmptyInstall');
|
Chris@0
|
55 }
|
Chris@0
|
56 }
|
Chris@0
|
57
|
Chris@0
|
58 }//end processFunction()
|
Chris@0
|
59
|
Chris@0
|
60
|
Chris@0
|
61 }//end class
|