annotate vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/NamingConventions/ValidVariableNameSniff.php @ 12:7a779792577d

Update Drupal core to v8.4.5 (via Composer)
author Chris Cannam
date Fri, 23 Feb 2018 15:52:07 +0000
parents 4c8ae668cc8c
children 129ea1e6d783
rev   line source
Chris@0 1 <?php
Chris@0 2 /**
Chris@0 3 * Drupal_Sniffs_NamingConventions_ValidVariableNameSniff.
Chris@0 4 *
Chris@0 5 * @category PHP
Chris@0 6 * @package PHP_CodeSniffer
Chris@0 7 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 8 */
Chris@0 9
Chris@0 10 /**
Chris@0 11 * Drupal_Sniffs_NamingConventions_ValidVariableNameSniff.
Chris@0 12 *
Chris@0 13 * Checks the naming of member variables.
Chris@0 14 *
Chris@0 15 * @category PHP
Chris@0 16 * @package PHP_CodeSniffer
Chris@0 17 * @link http://pear.php.net/package/PHP_CodeSniffer
Chris@0 18 */
Chris@0 19 class Drupal_Sniffs_NamingConventions_ValidVariableNameSniff
Chris@0 20
Chris@0 21 extends PHP_CodeSniffer_Standards_AbstractVariableSniff
Chris@0 22 {
Chris@0 23
Chris@0 24
Chris@0 25 /**
Chris@0 26 * Processes class member variables.
Chris@0 27 *
Chris@0 28 * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
Chris@0 29 * @param int $stackPtr The position of the current token
Chris@0 30 * in the stack passed in $tokens.
Chris@0 31 *
Chris@0 32 * @return void
Chris@0 33 */
Chris@0 34 protected function processMemberVar(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
Chris@0 35 {
Chris@0 36 $tokens = $phpcsFile->getTokens();
Chris@0 37
Chris@0 38 $memberProps = $phpcsFile->getMemberProperties($stackPtr);
Chris@0 39 if (empty($memberProps) === true) {
Chris@0 40 return;
Chris@0 41 }
Chris@0 42
Chris@0 43 $memberName = ltrim($tokens[$stackPtr]['content'], '$');
Chris@0 44
Chris@0 45 if (strpos($memberName, '_') === false) {
Chris@0 46 return;
Chris@0 47 }
Chris@0 48
Chris@0 49 // Check if the class extends another class and get the name of the class
Chris@0 50 // that is extended.
Chris@0 51 if (empty($tokens[$stackPtr]['conditions']) === false) {
Chris@0 52 $classPtr = key($tokens[$stackPtr]['conditions']);
Chris@0 53 $extendsName = $phpcsFile->findExtendedClassName($classPtr);
Chris@0 54
Chris@0 55 // Special case config entities: those are allowed to have underscores in
Chris@0 56 // their class property names. If a class extends something like
Chris@0 57 // ConfigEntityBase then we consider it a config entity class and allow
Chris@0 58 // underscores.
Chris@0 59 if ($extendsName !== false && strpos($extendsName, 'ConfigEntity') !== false) {
Chris@0 60 return;
Chris@0 61 }
Chris@0 62 }
Chris@0 63
Chris@0 64 $error = 'Class property %s should use lowerCamel naming without underscores';
Chris@0 65 $data = array($tokens[$stackPtr]['content']);
Chris@0 66 $phpcsFile->addError($error, $stackPtr, 'LowerCamelName', $data);
Chris@0 67
Chris@0 68 }//end processMemberVar()
Chris@0 69
Chris@0 70
Chris@0 71 /**
Chris@0 72 * Processes normal variables.
Chris@0 73 *
Chris@0 74 * @param PHP_CodeSniffer_File $phpcsFile The file where this token was found.
Chris@0 75 * @param int $stackPtr The position where the token was found.
Chris@0 76 *
Chris@0 77 * @return void
Chris@0 78 */
Chris@0 79 protected function processVariable(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
Chris@0 80 {
Chris@0 81 $tokens = $phpcsFile->getTokens();
Chris@0 82
Chris@0 83 $varName = ltrim($tokens[$stackPtr]['content'], '$');
Chris@0 84
Chris@0 85 $phpReservedVars = array(
Chris@0 86 '_SERVER',
Chris@0 87 '_GET',
Chris@0 88 '_POST',
Chris@0 89 '_REQUEST',
Chris@0 90 '_SESSION',
Chris@0 91 '_ENV',
Chris@0 92 '_COOKIE',
Chris@0 93 '_FILES',
Chris@0 94 'GLOBALS',
Chris@0 95 );
Chris@0 96
Chris@0 97 // If it's a php reserved var, then its ok.
Chris@0 98 if (in_array($varName, $phpReservedVars) === true) {
Chris@0 99 return;
Chris@0 100 }
Chris@0 101
Chris@0 102 // If it is a static public variable of a class, then its ok.
Chris@0 103 if ($tokens[($stackPtr - 1)]['code'] === T_DOUBLE_COLON) {
Chris@0 104 return;
Chris@0 105 }
Chris@0 106
Chris@0 107 if (preg_match('/^[A-Z]/', $varName) === 1) {
Chris@0 108 $error = "Variable \"$varName\" starts with a capital letter, but only \$lowerCamelCase or \$snake_case is allowed";
Chris@0 109 $phpcsFile->addError($error, $stackPtr, 'LowerStart');
Chris@0 110 }
Chris@0 111
Chris@0 112 }//end processVariable()
Chris@0 113
Chris@0 114
Chris@0 115 /**
Chris@0 116 * Processes variables in double quoted strings.
Chris@0 117 *
Chris@0 118 * @param PHP_CodeSniffer_File $phpcsFile The file where this token was found.
Chris@0 119 * @param int $stackPtr The position where the token was found.
Chris@0 120 *
Chris@0 121 * @return void
Chris@0 122 */
Chris@0 123 protected function processVariableInString(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
Chris@0 124 {
Chris@0 125 // We don't care about variables in strings.
Chris@0 126 return;
Chris@0 127
Chris@0 128 }//end processVariableInString()
Chris@0 129
Chris@0 130
Chris@0 131 }//end class