# HG changeset patch # User Chris Cannam # Date 1357900144 0 # Node ID e2f6bb97cc220d22706cf52a5c909a94be2d13c8 # Parent b16e8ef6919b4982aea5453154b99e0338ff3e05 Toolbar spacing adjustments; avoid using unified toolbar on Mac because it breaks the left toolbar with Qt 4.8 diff -r b16e8ef6919b -r e2f6bb97cc22 src/mainwindow.cpp --- a/src/mainwindow.cpp Fri Oct 19 12:08:11 2012 +0100 +++ b/src/mainwindow.cpp Fri Jan 11 10:29:04 2013 +0000 @@ -121,7 +121,6 @@ connect(m_hgTabs, SIGNAL(showAllChanged()), this, SLOT(showAllChanged())); - setUnifiedTitleAndToolBarOnMac(true); connectActions(); clearState(); enableDisableActions(); @@ -3085,24 +3084,44 @@ { int sz = 32; + QString spacerBefore, spacerAfter; + + spacerBefore = spacerAfter = " "; + +#ifdef Q_OS_MAC + spacerAfter = ""; +#endif + +#ifdef Q_OS_WIN32 + spacerBefore = spacerAfter = " " +#endif + bool spacingReqd = false; QString spacer = ""; -#ifndef Q_OS_MAC - spacingReqd = true; - spacer = " "; -#ifdef Q_OS_WIN32 - spacer = " "; -#endif -#endif + + m_repoToolBar = addToolBar(tr("Remote")); + m_repoToolBar->setIconSize(QSize(sz, sz)); + if (spacerBefore != "") { + m_repoToolBar->addWidget(new QLabel(spacerBefore)); + } + m_repoToolBar->addAction(m_openAct); + if (spacerAfter != "") { + m_repoToolBar->addWidget(new QLabel(spacerAfter)); + } + m_repoToolBar->addSeparator(); + m_repoToolBar->addAction(m_hgIncomingAct); + m_repoToolBar->addAction(m_hgPullAct); + m_repoToolBar->addAction(m_hgPushAct); + m_repoToolBar->setMovable(false); m_workFolderToolBar = new QToolBar(tr("Work")); addToolBar(Qt::LeftToolBarArea, m_workFolderToolBar); m_workFolderToolBar->setIconSize(QSize(sz, sz)); - if (spacingReqd) { - QWidget *w = new QWidget; - w->setFixedHeight(6); - m_workFolderToolBar->addWidget(w); - } + + QWidget *w = new QWidget; + w->setFixedHeight(6); + m_workFolderToolBar->addWidget(w); + m_workFolderToolBar->addAction(m_hgFolderDiffAct); m_workFolderToolBar->addSeparator(); m_workFolderToolBar->addAction(m_hgRevertAct); @@ -3114,21 +3133,6 @@ m_workFolderToolBar->addAction(m_hgRemoveAct); m_workFolderToolBar->setMovable(false); - m_repoToolBar = addToolBar(tr("Remote")); - m_repoToolBar->setIconSize(QSize(sz, sz)); - if (spacingReqd) { - m_repoToolBar->addWidget(new QLabel(spacer)); - } - m_repoToolBar->addAction(m_openAct); - if (spacingReqd) { - m_repoToolBar->addWidget(new QLabel(spacer)); - } - m_repoToolBar->addSeparator(); - m_repoToolBar->addAction(m_hgIncomingAct); - m_repoToolBar->addAction(m_hgPullAct); - m_repoToolBar->addAction(m_hgPushAct); - m_repoToolBar->setMovable(false); - updateToolBarStyle(); }