# HG changeset patch # User Chris Cannam # Date 1292531023 0 # Node ID bb89bcd8986bbcd4e0cab260821914f64bbaeaea # Parent a6ec8d0bdd34700d45471a5d26bb74e8edbc60f2 * Fixes to external program location logic on Win32 diff -r a6ec8d0bdd34 -r bb89bcd8986b hgrunner.cpp --- a/hgrunner.cpp Thu Dec 16 18:00:12 2010 +0000 +++ b/hgrunner.cpp Thu Dec 16 20:23:43 2010 +0000 @@ -369,11 +369,11 @@ m_proc = new QProcess; - QProcessEnvironment env = QProcessEnvironment::systemEnvironment(); - -#ifdef Q_OS_WIN32 - if (m_myDirPath != "") { - env.insert("PATH", m_myDirPath + ";" + env.value("PATH")); + QProcessEnvironment env = QProcessEnvironment::systemEnvironment(); + +#ifdef Q_OS_WIN32 + if (m_myDirPath != "") { + env.insert("PATH", m_myDirPath + ";" + env.value("PATH")); } #endif diff -r a6ec8d0bdd34 -r bb89bcd8986b mainwindow.cpp --- a/mainwindow.cpp Thu Dec 16 18:00:12 2010 +0000 +++ b/mainwindow.cpp Thu Dec 16 20:23:43 2010 +0000 @@ -411,7 +411,7 @@ bool found = false; foreach (QString base, bases) { diff = findInPath(base, m_myDirPath, true); - if (diff != base) { + if (diff != base && diff != base + ".exe") { found = true; break; } diff -r a6ec8d0bdd34 -r bb89bcd8986b settingsdialog.cpp --- a/settingsdialog.cpp Thu Dec 16 18:00:12 2010 +0000 +++ b/settingsdialog.cpp Thu Dec 16 20:23:43 2010 +0000 @@ -17,6 +17,7 @@ #include "settingsdialog.h" #include "common.h" +#include "debug.h" #include #include @@ -207,6 +208,7 @@ void SettingsDialog::accept() { + DEBUG << "SettingsDialog::accept" << endl; QSettings settings; settings.beginGroup("User Information"); settings.setValue("name", m_nameEdit->text());