# HG changeset patch # User Chris Cannam # Date 1341308585 -3600 # Node ID 98f57888d893b9d287c7d95fec87f55bdd617690 # Parent 10ef94e51f44155f080aaf1eae13cc035a11d16e Ensure the URL combo never defaults to something that is not a URL diff -r 10ef94e51f44 -r 98f57888d893 src/multichoicedialog.cpp --- a/src/multichoicedialog.cpp Tue Jul 03 10:08:44 2012 +0100 +++ b/src/multichoicedialog.cpp Tue Jul 03 10:43:05 2012 +0100 @@ -275,6 +275,17 @@ } } +bool +MultiChoiceDialog::urlComboNotUrl() const +{ + QString url = m_urlCombo->currentText(); + if (QRegExp("^\\w+://").indexIn(url) < 0) { + return true; + } else { + return false; + } +} + void MultiChoiceDialog::choiceChanged() { @@ -347,14 +358,18 @@ m_urlLabel->show(); m_urlCombo->show(); m_urlCombo->addItems(rf->getRecent()); - if (m_defaultEmpty[id]) m_urlCombo->lineEdit()->setText(""); + if (m_defaultEmpty[id] || urlComboNotUrl()) { + m_urlCombo->lineEdit()->setText(""); + } break; case UrlToDirectoryArg: m_urlLabel->show(); m_urlCombo->show(); m_urlCombo->addItems(rf->getRecent()); - if (m_defaultEmpty[id]) m_urlCombo->lineEdit()->setText(""); + if (m_defaultEmpty[id] || urlComboNotUrl()) { + m_urlCombo->lineEdit()->setText(""); + } m_fileLabel->setText(tr("&Folder:")); m_fileLabel->show(); m_fileCombo->show(); diff -r 10ef94e51f44 -r 98f57888d893 src/multichoicedialog.h --- a/src/multichoicedialog.h Tue Jul 03 10:08:44 2012 +0100 +++ b/src/multichoicedialog.h Tue Jul 03 10:43:05 2012 +0100 @@ -88,6 +88,7 @@ QAbstractButton *m_okButton; QString getDefaultPath() const; + bool urlComboNotUrl() const; }; #endif // MULTICHOICEDIALOG_H