diff src/mainwindow.cpp @ 520:a17c06f773cd

idiot -- we don't need to query bookmarks separately, we can just add them to the log template
author Chris Cannam
date Wed, 09 Nov 2011 13:04:00 +0000
parents 000f13faa089
children b5a342a71218
line wrap: on
line diff
--- a/src/mainwindow.cpp	Tue Nov 08 16:42:09 2011 +0000
+++ b/src/mainwindow.cpp	Wed Nov 09 13:04:00 2011 +0000
@@ -323,13 +323,6 @@
 */
 }
 
-void MainWindow::hgQueryBookmarks()
-{
-    QStringList params;
-    params << "bookmarks";
-    m_runner->requestAction(HgAction(ACT_QUERY_BOOKMARKS, m_workFolderPath, params));
-}
-
 void MainWindow::hgQueryHeadsActive()
 {
     QStringList params;
@@ -2202,10 +2195,6 @@
         // and some return with failure codes when something as basic
         // as the user closing the window via the wm happens
         return;
-    case ACT_QUERY_BOOKMARKS:
-        // probably just means we have an old Hg version: simply don't
-        // display bookmarks
-        return;
     case ACT_MERGE:
     case ACT_RETRY_MERGE:
         MoreInformationDialog::information
@@ -2297,26 +2286,6 @@
         m_currentBranch = output.trimmed();
         break;
 
-    case ACT_QUERY_BOOKMARKS:
-    {
-        m_bookmarks.clear();
-        QStringList outList = output.split('\n', QString::SkipEmptyParts);
-        foreach (QString line, outList) {
-            QStringList items = line.split(' ', QString::SkipEmptyParts);
-            if (items[0] == "*") {
-                if (items.size() == 3) {
-                    m_bookmarks[items[2]].push_back(items[1]);
-                }
-            } else {
-                if (items.size() == 2) {
-                    m_bookmarks[items[1]].push_back(items[0]);
-                }
-            }
-        }
-        m_hgTabs->setBookmarks(m_bookmarks);
-        break;
-    }
-
     case ACT_STAT:
         m_lastStatOutput = output;
         updateFileSystemWatcher();
@@ -2529,11 +2498,11 @@
     }
 
     // Sequence when no full log required:
-    //   paths -> branch -> stat -> bookmarks -> resolve-list -> heads ->
+    //   paths -> branch -> stat -> resolve-list -> heads ->
     //     incremental-log (only if heads changed) -> parents
     // 
     // Sequence when full log required:
-    //   paths -> branch -> stat -> bookmarks -> resolve-list -> heads ->
+    //   paths -> branch -> stat -> resolve-list -> heads ->
     //     parents -> log
     //
     // Note we want to call enableDisableActions only once, at the end
@@ -2575,10 +2544,6 @@
         break;
         
     case ACT_STAT:
-        hgQueryBookmarks();
-        break;
-
-    case ACT_QUERY_BOOKMARKS:
         hgResolveList();
         break;