comparison mainwindow.cpp @ 127:758471b71721

* Don't provide file list when committing, if the user didn't select files.  Previously we (perhaps inadvertantly) used a list of all files because we had generated that for display -- but it breaks merge-commits and it's probably unwise to mess with very long command lines.

 {
     QStringList params;
     QString comment;
 
     QStringList files = hgTabs->getSelectedCommittableFiles();
-    if (files.empty()) files = hgTabs->getAllCommittableFiles();
+    QStringList reportFiles = files;
+    if (reportFiles.empty()) reportFiles = hgTabs->getAllCommittableFiles();
 
     if (ConfirmCommentDialog::confirmAndGetLongComment
         (this,
          tr("Commit files"),
          tr("<h3>Commit files</h3><p>You are about to commit the following files:"),
          tr("<h3>Commit files</h3><p>You are about to commit %1 files."),
-         files,
+         reportFiles,
          comment)) {
 
         if ((justMerged == false) && //!!! review usage of justMerged, and how it interacts with asynchronous request queue
             !files.empty()) {
             // User wants to commit selected file(s) (and this is not merge commit, which would fail if we selected files)

     if (files.empty()) files = hgTabs->getAllRevertableFiles();
     
     if (ConfirmCommentDialog::confirmDangerousFilesAction
         (this,
          tr("Revert files"),
-         tr("<h3>Revert files</h3><p>You are about to <b>revert</b> the following files to their previous committed state.<br><br>This will <b>throw away any changes</b> that you have made to these files but have not committed."),
+         tr("<h3>Revert files</h3><p>You are about to <b>revert</b> the following files to their previous committed state.<br><br>This will <b>throw away any changes</b> that you have made to these files but have not committed:"),
          tr("<h3>Revert files</h3><p>You are about to <b>revert</b> %1 files.<br><br>This will <b>throw away any changes</b> that you have made to these files but have not committed."),
          files)) {
         
         if (files.empty()) {
             params << "revert" << "--no-backup";