Mercurial > hg > auditok
changeset 237:c684f90cc3cd
Raise ValueError for negative and null analysis window
author | Amine Sehili <amine.sehili@gmail.com> |
---|---|
date | Sat, 20 Jul 2019 12:10:11 +0100 |
parents | 8c92420d15d5 |
children | f16fc2c3d12b |
files | auditok/core.py tests/test_core.py |
diffstat | 2 files changed, 12 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/auditok/core.py Fri Jul 19 23:24:17 2019 +0100 +++ b/auditok/core.py Sat Jul 20 12:10:11 2019 +0100 @@ -104,6 +104,10 @@ analysis_window = kwargs.get( "analysis_window", kwargs.get("aw", DEFAULT_ANALYSIS_WINDOW) ) + if analysis_window <= 0: + raise ValueError( + "'analysis_window' ({}) must be > 0".format(analysis_window) + ) params = kwargs.copy() params["max_read"] = params.get("max_read", params.get("mr"))
--- a/tests/test_core.py Fri Jul 19 23:24:17 2019 +0100 +++ b/tests/test_core.py Sat Jul 20 12:10:11 2019 +0100 @@ -760,10 +760,17 @@ negative_max_dur=({"max_dur": -1},), zero_max_dur=({"max_dur": 0},), negative_max_silence=({"max_silence": -1},), + zero_analysis_window=({"analysis_window": 0},), + negative_analysis_window=({"analysis_window": -1},), ) def test_split_negative_temporal_params(self, wrong_param): - params = {"min_dur": 0.2, "max_dur": 0.5, "max_silence": 0.1} + params = { + "min_dur": 0.2, + "max_dur": 0.5, + "max_silence": 0.1, + "analysis_window": 0.1, + } params.update(wrong_param) with self.assertRaises(ValueError) as val_err: split(None, **params)