# HG changeset patch # User mas01cr # Date 1231601578 0 # Node ID 13de7ba2196669fbca867c5148d5ed1f14d2dc18 # Parent 4cb6c611f812af76fa6cd1321e8141f3f321b948 Continue removing uses of audiodb_query() Deal with four more libtests/ cases. Of course, it would probably be "nice" or "useful" to provide an audiodb_query() implemented in terms of audiodb_query_spec() -- but that is not a task that I would enjoy. diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0005/prog1.c --- a/libtests/0005/prog1.c Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0005/prog1.c Sat Jan 10 15:32:58 2009 +0000 @@ -1,56 +1,22 @@ #include "audioDB_API.h" #include "test_utils_lib.h" +int main(int argc, char **argv) { + adb_t *adb; -int main(int argc, char **argv){ + clean_remove_db(TESTDB); + if(!(adb = audiodb_create(TESTDB, 0, 0, 0))) + return 1; - int returnval=0; - adb_ptr mydbp={0}; - int ivals[10]; - double dvals[10]; - adb_insert_t myinsert={0}; - unsigned int myerr=0; - char * databasename="testdb"; - int myerror=0; + adb_datum_t datum = {2, 2, "testfeature", (double[4]) {0, 1, 1, 0}}; + if(audiodb_insert_datum(adb,&datum)) + return 1; + if(audiodb_l2norm(adb)) + return 1; - /* remove old directory */ - //if [ -f testdb ]; then rm -f testdb; fi - clean_remove_db(databasename); + audiodb_close(adb); - /* create new db */ - //${AUDIODB} -d testdb -N - mydbp=audiodb_create(databasename,0,0,0); - - - /* make a test file */ - //intstring 2 > testfeature - //floatstring 0 1 >> testfeature - //floatstring 1 0 >> testfeature - ivals[0]=2; - dvals[0]=0; dvals[1]=1; dvals[2]=1; dvals[3]=0; - maketestfile("testfeature",ivals,dvals,4); - - - /* insert */ - //${AUDIODB} -d testdb -I -f testfeature - myinsert.features="testfeature"; - myerr=audiodb_insert(mydbp,&myinsert); - - /* turn on l2norm */ - //echo running L2Norm - //${AUDIODB} -d testdb -L - myerror=audiodb_l2norm(mydbp); - if (myerror){ - returnval=-1; - } - - - /* close */ - audiodb_close(mydbp); - - - - return(returnval); + return 104; } diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0005/short-description --- a/libtests/0005/short-description Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0005/short-description Sat Jan 10 15:32:58 2009 +0000 @@ -1,1 +1,1 @@ -L2 Norm with lib +l2 norming after insertion with library diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0006/prog1.c --- a/libtests/0006/prog1.c Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0006/prog1.c Sat Jan 10 15:32:58 2009 +0000 @@ -1,134 +1,60 @@ #include "audioDB_API.h" #include "test_utils_lib.h" +int main(int argc, char **argv) { + adb_t *adb; -int main(int argc, char **argv){ + clean_remove_db(TESTDB); + if(!(adb = audiodb_create(TESTDB, 0, 0, 0))) + return 1; - int returnval=0; - adb_ptr mydbp={0}; - int ivals[10]; - double dvals[10]; - adb_insert_t myinsert={0}; - unsigned int myerr=0; - char * databasename="testdb"; - adb_query_t myadbquery={0}; - adb_queryresult_t myadbqueryresult={0}; - adb_query_t myadbquery2={0}; - adb_queryresult_t myadbqueryresult2={0}; - int size=0; + adb_datum_t feature = {2, 2, "testfeature", (double[4]) {0, 1, 1, 0}}; + if(audiodb_insert_datum(adb, &feature)) + return 1; + audiodb_l2norm(adb); + adb_datum_t query = {1, 2, "testquery", (double[2]) {0, 0.5}}; + adb_query_id_t qid = {0}; + qid.datum = &query; + qid.sequence_length = 1; + qid.sequence_start = 0; + adb_query_parameters_t parms = + {ADB_ACCUMULATION_PER_TRACK, ADB_DISTANCE_EUCLIDEAN_NORMED, 10, 10}; + adb_query_refine_t refine = {0}; + refine.hopsize = 1; - /* remove old directory */ - //if [ -f testdb ]; then rm -f testdb; fi - clean_remove_db(databasename); + adb_query_spec_t spec; + spec.qid = qid; + spec.params = parms; + spec.refine = refine; - /* create new db */ - //${AUDIODB} -d testdb -N - mydbp=audiodb_create(databasename,0,0,0); + adb_query_results_t *results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 2) return 1; + result_present_or_fail(results, "testfeature", 0, 0, 0); + result_present_or_fail(results, "testfeature", 2, 0, 1); + audiodb_query_free_results(adb, &spec, results); - /* create testfeature file */ - //intstring 2 > testfeature - //floatstring 0 1 >> testfeature - //floatstring 1 0 >> testfeature - ivals[0]=2; - dvals[0]=0; dvals[1]=1; dvals[2]=1; dvals[3]=0; - maketestfile("testfeature",ivals,dvals,4); + spec.params.npoints = 1; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 1) return 1; + result_present_or_fail(results, "testfeature", 0, 0, 0); + audiodb_query_free_results(adb, &spec, results); + spec.qid.datum->data = (double [2]) {0.5, 0}; + spec.params.npoints = 10; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 2) return 1; + result_present_or_fail(results, "testfeature", 0, 0, 1); + result_present_or_fail(results, "testfeature", 2, 0, 0); + audiodb_query_free_results(adb, &spec, results); - /* insert */ - //${AUDIODB} -d testdb -I -f testfeature - myinsert.features="testfeature"; - if(audiodb_insert(mydbp,&myinsert)){ - returnval=-1; - }; + spec.params.npoints = 1; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 1) return 1; + result_present_or_fail(results, "testfeature", 0, 0, 1); + audiodb_query_free_results(adb, &spec, results); + audiodb_close(adb); - /* turn on L2NORM */ - //# sequence queries require L2NORM - //${AUDIODB} -d testdb -L - audiodb_l2norm(mydbp); - - /* make a test query */ - //echo "query point (0.0,0.5)" - //intstring 2 > testquery - //floatstring 0 0.5 >> testquery - ivals[0]=2; - dvals[0]=0; dvals[1]=0.5; dvals[2]=0; dvals[3]=0; - maketestfile("testquery",ivals,dvals,2); - - /* test a sequence query */ - //${AUDIODB} -d testdb -Q sequence -l 1 -f testquery > testoutput - //echo testfeature 1 0 0 > test-expected-output - //cmp testoutput test-expected-output - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.sequencelength="1"; - audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - size=myadbqueryresult.sizeRlist; - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult,0,"testfeature",1,0,0)) {returnval = -1;}; - - - /* same but with limites */ - //${AUDIODB} -d testdb -Q sequence -l 1 -f testquery -n 1 > testoutput - //echo testfeature 0 0 0 > test-expected-output - //cmp testoutput test-expected-output - myadbquery.numpoints="1"; - audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - size=myadbqueryresult.sizeRlist; - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult,0,"testfeature",0,0,0)) {returnval = -1;}; - - /* make another query */ - //echo "query point (0.5,0.0)" - //intstring 2 > testquery - //floatstring 0.5 0 >> testquery - ivals[0]=2; - dvals[0]=0.5; dvals[1]=0.0; dvals[2]=0; dvals[3]=0; - maketestfile("testquery",ivals,dvals,2); - - - /* test new query */ - //${AUDIODB} -d testdb -Q sequence -l 1 -f testquery > testoutput - //echo testfeature 1 0 1 > test-expected-output - //cmp testoutput test-expected-output - - myadbquery2.querytype="sequence"; - myadbquery2.feature="testquery"; - myadbquery2.sequencelength="1"; - audiodb_query(mydbp,&myadbquery2,&myadbqueryresult2); - size=myadbqueryresult2.sizeRlist; - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult2,0,"testfeature",1,0,1)) {returnval = -1;}; - - - /* test new query with limits */ - myadbquery2.numpoints="1"; - audiodb_query(mydbp,&myadbquery2,&myadbqueryresult2); - size=myadbqueryresult2.sizeRlist; - - //${AUDIODB} -d testdb -Q sequence -l 1 -f testquery -n 1 > testoutput - //echo testfeature 0 0 1 > test-expected-output - //cmp testoutput test-expected-output - - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult2,0,"testfeature",0,0,1)) {returnval = -1;}; - - - - /* close */ - audiodb_close(mydbp); - - printf("returnval:%d\n",returnval); - return(returnval); + return(104); } - - diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0006/short-description --- a/libtests/0006/short-description Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0006/short-description Sat Jan 10 15:32:58 2009 +0000 @@ -1,1 +1,1 @@ -sequence search / 1 track with lib +sequence search / 1 track with library diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0007/prog1.c --- a/libtests/0007/prog1.c Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0007/prog1.c Sat Jan 10 15:32:58 2009 +0000 @@ -1,111 +1,62 @@ #include "audioDB_API.h" #include "test_utils_lib.h" +int main(int argc, char **argv) { + adb_t *adb; -int main(int argc, char **argv){ + clean_remove_db(TESTDB); + if(!(adb = audiodb_create(TESTDB, 0, 0, 0))) + return 1; - int returnval=0; - adb_ptr mydbp={0}; - int ivals[10]; - double dvals[10]; - adb_insert_t myinsert={0}; - unsigned int myerr=0; - char * databasename="testdb"; - adb_query_t myadbquery={0}; - adb_queryresult_t myadbqueryresult={0}; - // adbquery myadbquery2={0}; - // adbqueryresult myadbqueryresult2={0}; - int size=0; + adb_datum_t feature = {2, 2, "testfeature", (double[4]) {0, 1, 1, 0}}; + if(audiodb_insert_datum(adb, &feature)) + return 1; + audiodb_l2norm(adb); - /* remove old directory */ - clean_remove_db(databasename); + adb_datum_t query = {1, 2, "testquery", (double[2]) {0, 0.5}}; + adb_query_id_t qid = {0}; + qid.datum = &query; + qid.sequence_length = 16; + qid.sequence_start = 0; + adb_query_parameters_t parms = + {ADB_ACCUMULATION_PER_TRACK, ADB_DISTANCE_EUCLIDEAN_NORMED, 10, 10}; + adb_query_refine_t refine = {0}; + refine.hopsize = 1; - /* create new db */ - mydbp=audiodb_create(databasename,0,0,0); + adb_query_spec_t spec; + spec.qid = qid; + spec.params = parms; + spec.refine = refine; + adb_query_results_t *results = audiodb_query_spec(adb, &spec); + if(results) return 1; -//# tests that the lack of -l when the query sequence is shorter doesn't -//# segfault. + spec.params.npoints = 1; + results = audiodb_query_spec(adb, &spec); + if(results) return 1; - /* make test file */ - //intstring 2 > testfeature - //floatstring 0 1 >> testfeature - //floatstring 1 0 >> testfeature - ivals[0]=2; - dvals[0]=0; dvals[1]=1; dvals[2]=1; dvals[3]=0; - maketestfile("testfeature",ivals,dvals,4); + spec.qid.datum->data = (double [2]) {0.5, 0}; + spec.params.npoints = 10; + results = audiodb_query_spec(adb, &spec); + if(results) return 1; + + spec.params.npoints = 1; + results = audiodb_query_spec(adb, &spec); + if(results) return 1; - /* insert */ - //${AUDIODB} -d testdb -I -f testfeature - myinsert.features="testfeature"; - myerr=audiodb_insert(mydbp,&myinsert); - if(myerr){ returnval=-1; }; + /* the above tests mirror those in the audioDB command-line test + * suite. We can test for additional bad input cases too: */ + spec.qid.sequence_start = 1; + spec.qid.sequence_length = 1; + results = audiodb_query_spec(adb, &spec); + if(results) return 1; - /* turn on l2norm */ - //# sequence queries require L2NORM - //${AUDIODB} -d testdb -L - if(audiodb_l2norm(mydbp)){ returnval=-1; }; + /* and just sanity check that we haven't broken everything */ + spec.qid.sequence_start = 0; + spec.params.npoints = 2; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 2) return 1; + audiodb_query_free_results(adb, &spec, results); - - /* make query */ - //echo "query point (0.0,0.5)" - //intstring 2 > testquery - //floatstring 0 0.5 >> testquery - ivals[0]=2; - dvals[0]=0; dvals[1]=0.5; - maketestfile("testquery",ivals,dvals,2); - - -/* should fail */ - -//audioDB -Q sequence -d testdb -f testquery -//expect_clean_error_exit ${AUDIODB} -d testdb -Q sequence -f testquery - - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - //myadbquery.sequencelength="1"; - myerr=audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - size=myadbqueryresult.sizeRlist; - if (!myerr){ returnval = -1;}; - - -///* should fail */ -//expect_clean_error_exit ${AUDIODB} -d testdb -Q sequence -f testquery -n 1 - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.numpoints="1"; - myerr=audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - if(!myerr){ returnval=-1; }; - -/* query 2 */ -//echo "query point (0.5,0.0)" -//intstring 2 > testquery -//floatstring 0.5 0 >> testquery - ivals[0]=2; - dvals[0]=0.5; dvals[1]=0.0; - maketestfile("testquery",ivals,dvals,2); - -/* should fail */ -//expect_clean_error_exit ${AUDIODB} -d testdb -Q sequence -f testquery - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.numpoints=NULL; - myerr=audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - if(!myerr){ returnval=-1; }; - -/* should fail */ -//expect_clean_error_exit ${AUDIODB} -d testdb -Q sequence -f testquery -n 1 - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.numpoints="1"; - myerr=audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - if(!myerr){ returnval=-1; }; - - - - - //printf("returnval:%d\n", returnval); - - return(returnval); + return 104; } - diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0007/short-description --- a/libtests/0007/short-description Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0007/short-description Sat Jan 10 15:32:58 2009 +0000 @@ -1,1 +1,1 @@ -short query [no -l] error with lib +short query [no -l] error with library diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0008/prog1.c --- a/libtests/0008/prog1.c Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0008/prog1.c Sat Jan 10 15:32:58 2009 +0000 @@ -1,152 +1,64 @@ #include "audioDB_API.h" #include "test_utils_lib.h" +int main(int argc, char **argv) { + adb_t *adb; -int main(int argc, char **argv){ + clean_remove_db(TESTDB); + if(!(adb = audiodb_create(TESTDB,0,0,0))) + return 1; - int returnval=0; - adb_ptr mydbp={0}; - int ivals[10]; - double dvals[10]; - adb_insert_t myinsert={0}; - unsigned int myerr=0; - char * databasename="testdb"; - adb_query_t myadbquery={0}; - adb_queryresult_t myadbqueryresult={0}; - adb_query_t myadbquery2={0}; - adb_queryresult_t myadbqueryresult2={0}; - int size=0; + adb_datum_t datum1 = {1, 2, "testfeature01", (double[4]) {0, 1}}; + adb_datum_t datum2 = {1, 2, "testfeature10", (double[4]) {1, 0}}; + if(audiodb_insert_datum(adb, &datum1)) + return 1; + if(audiodb_insert_datum(adb, &datum2)) + return 1; + if(audiodb_l2norm(adb)) + return 1; + adb_datum_t query = {1, 2, "testquery", (double[2]) {0, 0.5}}; + adb_query_id_t qid = {0}; + qid.datum = &query; + qid.sequence_length = 1; + qid.sequence_start = 0; + adb_query_parameters_t parms = + {ADB_ACCUMULATION_PER_TRACK, ADB_DISTANCE_EUCLIDEAN_NORMED, 10, 10}; + adb_query_refine_t refine = {0}; + refine.hopsize = 1; - /* remove old directory */ - clean_remove_db(databasename); + adb_query_spec_t spec; + spec.qid = qid; + spec.params = parms; + spec.refine = refine; + + adb_query_results_t *results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 2) return 1; + result_present_or_fail(results, "testfeature01", 0, 0, 0); + result_present_or_fail(results, "testfeature10", 2, 0, 0); + audiodb_query_free_results(adb, &spec, results); + spec.params.ntracks = 1; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 1) return 1; + result_present_or_fail(results, "testfeature01", 0, 0, 0); + audiodb_query_free_results(adb, &spec, results); + spec.qid.datum->data = (double[2]) {0.5, 0}; + spec.params.ntracks = 10; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 2) return 1; + result_present_or_fail(results, "testfeature10", 0, 0, 0); + result_present_or_fail(results, "testfeature01", 2, 0, 0); + audiodb_query_free_results(adb, &spec, results); -//${AUDIODB} -d testdb -N - /* create new db */ - mydbp=audiodb_create(databasename,0,0,0); + spec.params.ntracks = 1; + results = audiodb_query_spec(adb, &spec); + if(!results || results->nresults != 1) return 1; + result_present_or_fail(results, "testfeature10", 0, 0, 0); + audiodb_query_free_results(adb, &spec, results); - -//intstring 2 > testfeature01 -//floatstring 0 1 >> testfeature01 -//intstring 2 > testfeature10 -//floatstring 1 0 >> testfeature10 - - /* create testfeature01 file */ - ivals[0]=2; - dvals[0]=0; dvals[1]=1; dvals[2]=0; dvals[3]=0; - maketestfile("testfeature01",ivals,dvals,2); - - /* create testfeature10 file */ - ivals[0]=2; - dvals[0]=1; dvals[1]=0; dvals[2]=0; dvals[3]=0; - maketestfile("testfeature10",ivals,dvals,2); - -//${AUDIODB} -d testdb -I -f testfeature01 -//${AUDIODB} -d testdb -I -f testfeature10 - - /* insert */ - myinsert.features="testfeature01"; - myerr=audiodb_insert(mydbp,&myinsert); - - myinsert.features="testfeature10"; - myerr=audiodb_insert(mydbp,&myinsert); - -//# sequence queries require L2NORM -//${AUDIODB} -d testdb -L - audiodb_l2norm(mydbp); - -//echo "query point (0.0,0.5)" -//intstring 2 > testquery -//floatstring 0 0.5 >> testquery - - /* create testquery file */ - ivals[0]=2; - dvals[0]=0.0; dvals[1]=0.5; dvals[2]=0; dvals[3]=0; - maketestfile("testquery",ivals,dvals,2); - -//${AUDIODB} -d testdb -Q sequence -l 1 -f testquery > testoutput -//echo testfeature01 0 0 0 > test-expected-output -//echo testfeature10 2 0 0 >> test-expected-output -//cmp testoutput test-expected-output - - /* query */ - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.sequencelength="1"; - audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - size=myadbqueryresult.sizeRlist; - - - - /* check the test values */ - if (size != 2) {returnval = -1;}; - if (testoneresult(&myadbqueryresult,0,"testfeature01",0,0,0)) {returnval = -1;}; - if (testoneresult(&myadbqueryresult,1,"testfeature10",2,0,0)) {returnval = -1;}; - -////${AUDIODB} -d testdb -Q sequence -l 1 -f testquery -r 1 > testoutput -////echo testfeature01 0 0 0 > test-expected-output -////cmp testoutput test-expected-output - - myadbquery.querytype="sequence"; - myadbquery.feature="testquery"; - myadbquery.sequencelength="1"; - myadbquery.resultlength="1"; - audiodb_query(mydbp,&myadbquery,&myadbqueryresult); - size=myadbqueryresult.sizeRlist; - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult,0,"testfeature01",0,0,0)) {returnval = -1;}; - -//echo "query point (0.5,0.0)" -//intstring 2 > testquery -//floatstring 0.5 0 >> testquery - - /* create testquery file */ - ivals[0]=2; - dvals[0]=0.5; dvals[1]=0.0; dvals[2]=0; dvals[3]=0; - maketestfile("testquery",ivals,dvals,2); - -//${AUDIODB} -d testdb -Q sequence -l 1 -f testquery > testoutput -//echo testfeature10 0 0 0 > test-expected-output -//echo testfeature01 2 0 0 >> test-expected-output -//cmp testoutput test-expected-output - - myadbquery2.querytype="sequence"; - myadbquery2.feature="testquery"; - myadbquery2.sequencelength="1"; - audiodb_query(mydbp,&myadbquery2,&myadbqueryresult2); - size=myadbqueryresult2.sizeRlist; - - /* check the test values */ - if (size != 2) {returnval = -1;}; - if (testoneresult(&myadbqueryresult2,0,"testfeature10",0,0,0)) {returnval = -1;}; - if (testoneresult(&myadbqueryresult2,1,"testfeature01",2,0,0)) {returnval = -1;}; - - -//${AUDIODB} -d testdb -Q sequence -l 1 -f testquery -r 1 > testoutput -//echo testfeature10 0 0 0 > test-expected-output -//cmp testoutput test-expected-output - - - myadbquery2.querytype="sequence"; - myadbquery2.feature="testquery"; - myadbquery2.sequencelength="1"; - myadbquery2.resultlength="1"; - audiodb_query(mydbp,&myadbquery2,&myadbqueryresult2); - size=myadbqueryresult2.sizeRlist; - - - /* check the test values */ - if (size != 1) {returnval = -1;}; - if (testoneresult(&myadbqueryresult2,0,"testfeature10",0,0,0)) {returnval = -1;}; - - - - return(returnval); + return 104; } - diff -r 4cb6c611f812 -r 13de7ba21966 libtests/0008/short-description --- a/libtests/0008/short-description Sat Jan 10 15:32:53 2009 +0000 +++ b/libtests/0008/short-description Sat Jan 10 15:32:58 2009 +0000 @@ -1,1 +1,1 @@ -sequence search / 2 tracks with lib +sequence search / 2 tracks with library