Mercurial > hg > audiodb
view tests/0035/run-test.sh @ 405:ef4792df8f93 api-inversion
invert audioDB::insert / audiodb_insert().
Start off by removing audioDB::insertDatum, and essentially reusing it
as audiodb_insert. We now ignore the fact that the command-line parsing
code has "helpfully" opened a std::ifstream for the times file and an fd
for the power file, and simply go ahead and do our own dirty work.
We can delete audioDB::insertDatum entirely, but unfortunately we can't
delete audioDB::insertPowerData and audioDB::insertTimestamps, because
the index and query code respectively use them. Instead, move the two
methods closer to their single uses.
audiodb_insert() is perhaps not as short and simple as it might have
been hoped given the existence of audiodb_insert_datum(); some of that
is C and its terribly way of making you pay every time you use dynamic
memory; some of it is the fact that the three different files (feature,
times, power) each requires slightly different treatment. Hey ho.
We can implement audiodb_batchinsert() in terms of audiodb_insert(); the
function is pleasingly small. We can't quite use it for
audioDB::batchinsert yet, as we have to deal with the O2_FLAG_LARGE_ADB
case (which codepath is untested in libtests/).
This means that we can delete whole swathes of hideous code from
audioDB.cpp, including not just the versions of audiodb_insert() and
audiodb_batchinsert() but also an entire audioDB constructor. Yay.
(audioDB::unitNormAndInsertL2 has also died a deserved death).
author | mas01cr |
---|---|
date | Fri, 05 Dec 2008 22:32:49 +0000 |
parents | fe4dc39b2dd7 |
children |
line wrap: on
line source
#! /bin/bash . ../test-utils.sh if [ -f testdb ]; then rm -f testdb; fi ${AUDIODB} -d testdb -N intstring 2 > testfeature1 floatstring 0 1 >> testfeature1 intstring 2 > testfeature3 floatstring 1 0 >> testfeature3 floatstring 0 1 >> testfeature3 floatstring 1 0 >> testfeature3 ${AUDIODB} -d testdb -I -f testfeature1 ${AUDIODB} -d testdb -I -f testfeature3 # sequence queries require L2NORM ${AUDIODB} -d testdb -L echo "query point (0 1, 1 0)" intstring 2 > testquery floatstring 0 1 >> testquery floatstring 1 0 >> testquery ${AUDIODB} -d testdb -Q sequence -l 2 -f testquery -n 1 > testoutput wc -l testoutput | grep "1 testoutput" grep "^testfeature3 .* 0 1$" testoutput exit 104