Mercurial > hg > audiodb
view tests/0017/run-test.sh @ 400:8c7453fb5bd9 api-inversion
Invert audioDB::power_flag / audiodb_power()
Here the exciting discovery is that the mmap(), memcpy(), munmap()
sequence is in fact not safe. In principle an msync() call should be
inserted before unmapping for in-core changes to mmap()ed files to be
flushed to disk.
In this case we work around the problem entirely, by not mmap()ing
anything and doing everything with file descriptors. Amusingly, that's
probably not desperately safe either, this time because we have to move
the file descriptor position (which is also a shared resource). dup()
doesn't save us, as the duplicate file descriptor shares a file
position.
This applies also to the filling of data_buffer in the query loop, and
in fact basically any call to lseek(), which is why I'm not fixing it
now. Solution: if you have multiple threads all acting at once on a
single database, do one audiodb_open() per thread, for now at least.
author | mas01cr |
---|---|
date | Thu, 27 Nov 2008 16:22:52 +0000 |
parents | fe4dc39b2dd7 |
children |
line wrap: on
line source
#! /bin/bash . ../test-utils.sh if [ -f testdb ]; then rm -f testdb; fi ${AUDIODB} -d testdb -N # tests that the lack of -l when the query sequence is shorter doesn't # segfault. intstring 2 > testfeature floatstring 0 1 >> testfeature floatstring 1 0 >> testfeature ${AUDIODB} -d testdb -I -f testfeature # sequence queries require L2NORM ${AUDIODB} -d testdb -L start_server ${AUDIODB} 10017 echo "query point (0.0,0.5)" intstring 2 > testquery floatstring 0 0.5 >> testquery # FIXME: this actually revealed a horrible failure mode of the server: # since we were throwing exceptions from the constructor, the # destructor wasn't getting called and so we were retaining 2Gb of # address space, leading to immediate out of memory errors for the # /second/ call. We fix that by being a bit more careful about our # exception handling and cleanup discipline, but how to test...? expect_client_failure ${AUDIODB} -c localhost:10017 -d testdb -Q sequence -f testquery expect_client_failure ${AUDIODB} -c localhost:10017 -d testdb -Q sequence -f testquery -n 1 check_server $! echo "query point (0.5,0.0)" intstring 2 > testquery floatstring 0.5 0 >> testquery expect_client_failure ${AUDIODB} -c localhost:10017 -d testdb -Q sequence -f testquery expect_client_failure ${AUDIODB} -c localhost:10017 -d testdb -Q sequence -f testquery -n 1 check_server $! # see if the server can actually produce any output at this point ${AUDIODB} -c localhost:10017 -d testdb -Q sequence -l 1 -f testquery -n 1 > testoutput echo testfeature 0 0 1 > test-expected-output cmp testoutput test-expected-output stop_server $! exit 104