Mercurial > hg > audiodb
diff common.cpp @ 363:64d5de8b1a68 gcc-4.3-cleanups
Initialize UseApiError to 0 (false) in audioDB constructors.
(Previous gccs might or might not default to 0, depending on the phase
of the moon; gcc 4.3 really doesn't.)
author | mas01cr |
---|---|
date | Wed, 12 Nov 2008 14:01:06 +0000 |
parents | 94c18f128ce8 |
children | 4e68f7d4d524 342822c2d49a fbcc1303dfeb |
line wrap: on
line diff
--- a/common.cpp Wed Nov 12 13:05:14 2008 +0000 +++ b/common.cpp Wed Nov 12 14:01:06 2008 +0000 @@ -53,15 +53,15 @@ if(isServer) { - /* FIXME: I think this is leaky -- we never delete err. actually - deleting it is tricky, though; it gets placed into some - soap-internal struct with uncertain extent... -- CSR, - 2007-10-01 */ - char *err = new char[256]; /* FIXME: overflows */ - snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : ""); - /* FIXME: actually we could usefully do with a properly structured - type, so that we can throw separate faultstring and details. - -- CSR, 2007-10-01 */ + /* FIXME: I think this is leaky -- we never delete err. + actually deleting it is tricky, though; it gets placed into + some soap-internal struct with uncertain extent... -- CSR, + 2007-10-01 */ + char *err = new char[256]; /* FIXME: overflows */ + snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : ""); + /* FIXME: actually we could usefully do with a properly + structured type, so that we can throw separate faultstring + and details. -- CSR, 2007-10-01 */ throw(err); } else if (UseApiError){ apierrortemp=-1;