diff common.cpp @ 370:2d5c3f8e8c22

Merge gcc-4.3-cleanups branch (-r629:642, but I consider that branch as
having served its purpose) onto the trunk.

Now compiles cleanly even with a fairly picky gcc.  I await version 4.4
with bated breath.

--- a/common.cpp	Wed Nov 12 10:21:06 2008 +0000
+++ b/common.cpp	Wed Nov 12 15:40:40 2008 +0000
@@ -53,15 +53,15 @@
  
 
     if(isServer) {
-    /* FIXME: I think this is leaky -- we never delete err.  actually
-       deleting it is tricky, though; it gets placed into some
-       soap-internal struct with uncertain extent... -- CSR,
-       2007-10-01 */
-    char *err = new char[256]; /* FIXME: overflows */
-    snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : "");
-    /* FIXME: actually we could usefully do with a properly structured
-       type, so that we can throw separate faultstring and details.
-       -- CSR, 2007-10-01 */
+        /* FIXME: I think this is leaky -- we never delete err.
+           actually deleting it is tricky, though; it gets placed into
+           some soap-internal struct with uncertain extent... -- CSR,
+           2007-10-01 */
+        char *err = new char[256]; /* FIXME: overflows */
+        snprintf(err, 255, "%s: %s\n%s", a, b, sysFunc ? strerror(errno) : "");
+        /* FIXME: actually we could usefully do with a properly
+           structured type, so that we can throw separate faultstring
+           and details.  -- CSR, 2007-10-01 */
         throw(err);
     } else if (UseApiError){
         apierrortemp=-1;