comparison create.cpp @ 410:d7e590d58c85 api-inversion

Pavlovian response to compiler warnings...

... attempt to squash them.  For now we can get most of the way by
writing a simple write_or_goto_error() macro for write(), and the
equivalent for read().

One of the warnings, for the return value of chdir(), is silly, because
we're already in an error case, and we really can't do anything sensible
if the chdir fails.  Try to deal with it anyway.

 #include "audioDB.h"
 extern "C" {
 #include "audioDB_API.h"
 }
+#include "audioDB-internals.h"
+
 /* Make a new database.
 
 IF size(featuredata) < O2_LARGE_ADB_SIZE
    The database consists of:
 

     header->powerTableOffset = ALIGN_PAGE_UP(header->timesTableOffset + O2_FILETABLE_ENTRY_SIZE*ntracks);
     header->l2normTableOffset = ALIGN_PAGE_UP(header->powerTableOffset + O2_FILETABLE_ENTRY_SIZE*ntracks);
     header->dbSize = header->l2normTableOffset;
   }
 
-  if (write(fd, header, O2_HEADERSIZE) != O2_HEADERSIZE) {
-    goto error;
-  }
+  write_or_goto_error(fd, header, O2_HEADERSIZE);
 
   // go to the location corresponding to the last byte
   if (lseek (fd, header->dbSize - 1, SEEK_SET) == -1) {
     goto error;
   }
 
   // write a dummy byte at the last location
-  if (write (fd, "", 1) != 1) {
-      goto error;
-  }
+  write_or_goto_error(fd, "", 1);
 
   free(header);
   return audiodb_open(path, O_RDWR);
 
  error: