Bug #387

tempo calculation is buggy + fix

Added by Matthias Mauch over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:2012-02-14
Priority:High Due date:
Assignee:Matthias Mauch % Done:

100%

Category:-
Target version:-

Description

Hi,

Because in main.cpp, lines 106-108 the bytes are read as int, the values can become negative and the subsequent tempo calculation goes wrong. When corrected by using unsigned chars as here:

            unsigned char m0 = j->getMetaMessage()[0];
            unsigned char m1 = j->getMetaMessage()[1];
            unsigned char m2 = j->getMetaMessage()[2];

the tempo calculation works fine.
Matthias

History

Updated by Matthias Mauch over 1 year ago

  • Assignee set to Matthias Mauch
  • % Done changed from 0 to 100

fixed, as far as I can see... might need a quick review from Cannam, since I'm still a beginner.

Updated by Matthias Mauch over 1 year ago

  • Status changed from New to Closed

Also available in: Atom PDF